Avoid leaking DHCHAP keys to the host system#1165
Draft
mxsrc wants to merge 1 commit into
Draft
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
mxsrc
force-pushed
the
spdk-keyring-hardening
branch
from
5ec7173 to
b9fa48a
Compare
The previous mount was backed on the host and accumulated keys of all SPDK pods on a host over time. The new approach uses a combined operation. The keys are backed by a memory volume only shared between SPDK container and proxy, making them ephemeral.
mxsrc
force-pushed
the
spdk-keyring-hardening
branch
from
b9fa48a to
fee1118
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous mount was backed on the host and accumulated keys of all SPDK pods on a host over time. The new approach uses a combined operation. The keys are backed by a memory volume only shared between SPDK container and proxy, making them ephemeral.
This PR leaves the old endpoints and functions available s.t. the SPDK/SNode containers can be updated first. The logic is to be removed in a future release.