improvement(tools): validate integrations, add Gong activity tools, regenerate docs by waleedlatif1 · Pull Request #4937 · simstudioai/sim

waleedlatif1 · 2026-06-10T03:11:43Z

Summary

Audited and validated ~15 tool integrations against their API docs (gong, okta, databricks, servicenow, dub, enrich, fireflies, duckduckgo, workday, brightdata, mailchimp, millionverifier, zerobounce, google_pagespeed, intercom)
Gong: fixed block outputs to match actual tool outputs, added AI spotlight content (brief/outline/keyPoints/callOutcome) to extensive calls, and added Day-by-Day Activity + Aggregate by Period tools
ServiceNow: added boundary contract + route
Regenerated tool docs and the integration catalog

Type of Change

Improvement / validation hardening

Testing

Tested manually — lint, typecheck, and api-validation pass; block registry + Gong webhook tests green

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…egenerate docs

vercel · 2026-06-10T03:11:49Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jun 10, 2026 3:38am

cursor · 2026-06-10T03:11:54Z

PR Summary

Medium Risk
Touches HR (Workday), ITSM (ServiceNow file upload with credentials), and many external API payloads; incorrect SOAP or attachment handling could break production workflows, though changes are mostly additive documentation and new operations.

Overview
This PR hardens and expands many Sim tool integrations after API-doc validation, and regenerates matching docs and the integration catalog.

Gong adds Day-by-Day Activity and Aggregate by Period tools; Get Extensive Calls now documents AI spotlight fields (brief, outline, key points, call outcome). The Gong block outputs are expanded from a single generic response to typed fields aligned with each operation.

Databricks gains four operations—Get Statement, List Warehouses, Get Job, Get Cluster—with new tools, block wiring, and .trim() on workspace host URLs across existing Databricks HTTP tools.

Dub adds bulk create/update/delete, Count Links, List Events, and Get QR Code, plus block UI for cloaking/archived and the new filters; list-links sort params are dropped from docs.

ServiceNow adds aggregate, list/download/upload attachments, a upload-attachment API route (auth, file access checks), contracts export, and authMode: ApiKey in the catalog.

Enrich adds Search Jobs and LinkedIn post reactions/comments by URL. Fireflies adds list skip, bite media type, and delete returns the removed transcript. DuckDuckGo exposes definition and bang redirect outputs. Google PageSpeed splits the monolithic response into individual metric outputs.

Workday fixes Change Job SOAP (supervisory org, proposed position, nested job details) and Update Worker payload key. Okta omits blank params on partial updates so empty strings do not clear fields.

Branding/docs: several integrations switch block/card bgColor (e.g. Bright Data, Intercom, Mailchimp yellow, verifiers white); two icons use fixed black fill instead of currentColor.

^{Reviewed by Cursor Bugbot for commit 4615046. Configure here.}

Read Records and List Attachments shared the subBlock id 'limit', so the single-value-per-id store could bleed the value across operations. Rename the new list-attachments field to attachmentLimit and map it back to the tool's limit param.

…pecheck secureFetchWithValidation's response.json() resolves to unknown under the build's stricter typecheck; cast the parsed body so data.result is accessible.

…convention Match the SharePoint/OneDrive upload pattern: import the named ServiceNowAttachment type from the tool's types, cast response.json() to it, and extract specific fields with ?? null instead of passing data.result through as an opaque unknown blob.

waleedlatif1 · 2026-06-10T03:27:01Z

@greptile

waleedlatif1 · 2026-06-10T03:27:05Z

@cursor review

…wandConfig 'custom' is not a member of the GenerationType union, breaking the build typecheck. No valid type fits a comma-separated field list, so drop the wandConfig (consistent with the block's other field-list inputs).

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 4615046. Configure here.}

greptile-apps · 2026-06-10T03:32:05Z

Greptile Summary

This PR audits and validates ~15 tool integrations against their respective APIs, adds two new Gong activity tools (day-by-day and aggregate-by-period), enriches the get_extensive_calls tool with AI Spotlight content fields, expands ServiceNow with aggregate and attachment tools, and corrects Workday SOAP API field names. Documentation and the integration catalog are also regenerated.

Gong: Two new activity tools (day_by_day_activity, aggregate_by_period) added with correct request shapes, type-safe response parsing, and consistent pagination cursor handling; AI Spotlight fields (brief, outline, keyPoints, callOutcome) added to the get_extensive_calls content selector.
ServiceNow: New aggregate, list_attachments, download_attachment, and upload_attachment tools added alongside a properly validated route contract; a dedicated Next.js route handles the multipart upload with auth and file-access checks.
Workday / Okta / ~13 other integrations: API-level corrections (wrong XML element names, wrong Okta reference type, endpoint URL corrections, empty-string filtering on partial updates, DuckDuckGo disambiguation flattening, Enrich v1 endpoint migration with 202 handling).

Confidence Score: 4/5

The changes are primarily additive API fixes and new tool additions; existing functionality is not broken, and the new routes follow established auth and validation patterns.

The bulk of the PR is API-correctness hardening and well-contained new tools. One new parameter (fileContent) uses the wrong visibility level, which is a style inconsistency with the project's visibility conventions rather than a runtime defect. All auth, routing, and data-flow logic looks sound.

apps/sim/tools/servicenow/upload_attachment.ts — the fileContent visibility level warrants a quick look.

Important Files Changed

Filename	Overview
apps/sim/tools/gong/aggregate_by_period.ts	New Gong aggregate-by-period tool — follows existing activity tool patterns with correct cursor path and type safety.
apps/sim/tools/gong/day_by_day_activity.ts	New Gong day-by-day activity tool — correct request body shape, cursor access consistent with sibling tools.
apps/sim/tools/gong/get_extensive_calls.ts	AI Spotlight fields added to contentSelector and output schema; transformResponse passes through the full call object, so nested content fields flow through correctly.
apps/sim/app/api/tools/servicenow/upload-attachment/route.ts	New ServiceNow upload-attachment route — auth, file access authorization, and error handling look correct.
apps/sim/tools/servicenow/upload_attachment.ts	New upload-attachment tool — one issue: fileContent uses visibility: 'hidden' but should be 'user-only' per project rules.
apps/sim/app/api/tools/workday/change-job/route.ts	API-correct fixes: Position_Reference → Proposed_Position_Reference, supervisor org type corrected, job profile/location moved under Job_Details_Data sub-structure.
apps/sim/app/api/tools/workday/update-worker/route.ts	Corrects XML wrapper element name to Change_Personal_Information_Business_Process_Data, matching Workday SOAP API spec.
apps/sim/tools/duckduckgo/search.ts	Correctly flattens nested disambiguation groups in RelatedTopics, adds definition and redirect fields to output.
apps/sim/tools/servicenow/aggregate.ts	New ServiceNow aggregate tool — clean implementation with correct URL construction and grouped vs ungrouped result handling.
apps/sim/blocks/blocks/okta.ts	Correctly filters empty strings from partial-update params to prevent overwriting existing Okta values with empty strings.
apps/sim/tools/enrich/linkedin_to_personal_email.ts	API endpoint corrected to v1 with new param name; graceful handling of in-progress/queued 202 responses added.
apps/sim/lib/api/contracts/tools/servicenow.ts	New Zod contract for the upload-attachment route — properly validates required fields and optional file inputs.
apps/sim/tools/gong/types.ts	New types for DayByDayActivity and AggregateByPeriod responses are well-typed and consistent with existing patterns.

_{Reviews (1): Last reviewed commit: "fix(servicenow): remove invalid 'custom'..." | Re-trigger Greptile}

…attachment Per project rule, visibility:'hidden' is reserved for framework-injected tokens, not user-supplied data. fileContent was a copied-over legacy fallback with no caller (the block uploads via the canonical file/UserFile path), so remove it from the tool, types, contract, and route.

Bulk Update Links could run with only Update Data and no Link IDs or External IDs, sending Dub a request with no target links and producing a confusing API error. Guard the tool to throw a clear validation error when neither selector is provided, and clarify the block placeholder.

improvement(tools): validate integrations, add Gong activity tools, r…

d651fce

…egenerate docs

waleedlatif1 mentioned this pull request Jun 10, 2026

v0.7.0: vibes improvement, new UI, new tools, chat-first, mothership updates #4922

Merged

cursor Bot reviewed Jun 10, 2026

View reviewed changes

Comment thread apps/sim/blocks/blocks/servicenow.ts

vercel Bot deployed to Preview June 10, 2026 03:15 View deployment

vercel Bot temporarily deployed to Preview June 10, 2026 03:18 Inactive

fix(servicenow): type upload-attachment response json to fix build ty…

584c5ca

…pecheck secureFetchWithValidation's response.json() resolves to unknown under the build's stricter typecheck; cast the parsed body so data.result is accessible.

vercel Bot temporarily deployed to Preview June 10, 2026 03:20 Inactive

vercel Bot temporarily deployed to Preview June 10, 2026 03:22 Inactive

vercel Bot temporarily deployed to Preview June 10, 2026 03:29 Inactive

cursor Bot reviewed Jun 10, 2026

View reviewed changes

Comment thread apps/sim/blocks/blocks/dub.ts

greptile-apps Bot reviewed Jun 10, 2026

View reviewed changes

Comment thread apps/sim/tools/servicenow/upload_attachment.ts Outdated

vercel Bot temporarily deployed to Preview June 10, 2026 03:37 Inactive

vercel Bot temporarily deployed to Preview June 10, 2026 03:38 Inactive

waleedlatif1 merged commit 62c48bf into staging Jun 10, 2026
9 checks passed

waleedlatif1 deleted the feat/tools-new branch June 10, 2026 03:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improvement(tools): validate integrations, add Gong activity tools, regenerate docs#4937

improvement(tools): validate integrations, add Gong activity tools, regenerate docs#4937
waleedlatif1 merged 7 commits into
stagingfrom
feat/tools-new

waleedlatif1 commented Jun 10, 2026

Uh oh!

vercel Bot commented Jun 10, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Jun 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

waleedlatif1 commented Jun 10, 2026

Uh oh!

waleedlatif1 commented Jun 10, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

greptile-apps Bot commented Jun 10, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

waleedlatif1 commented Jun 10, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

waleedlatif1 commented Jun 10, 2026

Uh oh!

waleedlatif1 commented Jun 10, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot commented Jun 10, 2026

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Jun 10, 2026 •

edited

Loading

cursor Bot commented Jun 10, 2026 •

edited

Loading