fix(secrets): keep readonly secret names legible instead of dimming them#4942
Conversation
Readonly viewers saw the workspace secret name at opacity-50 while the masked value rendered at full opacity, an inconsistent and hostile treatment of content they need to read. Drop the opacity dim on the non-renameable key; non-editability is already conveyed by the read-only field and absent edit affordances.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview
Reviewed by Cursor Bugbot for commit f9e85bf. Configure here. |
Greptile SummaryThis PR removes
Confidence Score: 5/5Safe to merge — a single Tailwind class swap with no logic changes, no data-flow impact, and no security implications. The change is a one-line CSS class update on a purely presentational read-only field. It removes a visual inconsistency without touching any state, permissions logic, or API calls. The field remains non-editable for viewers; only the cursor style and opacity change. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[WorkspaceVariableRow renders] --> B{canRename?}
B -- Yes --> C[ChipInput: no extra className\neditable, cursor-default]
B -- No --> D["ChipInput: className='cursor-text'\nreadOnly, full opacity\ntext is selectable/copyable"]
D --> E[No opacity-50 dim\nNo cursor-not-allowed]
Reviews (2): Last reviewed commit: "fix(secrets): use cursor-text on readonl..." | Re-trigger Greptile |
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f9e85bf. Configure here.
Summary
opacity-50while the masked value next to it rendered at full opacity — an inconsistent, hostile treatment of content they need to read.Type of Change
Testing
Tested manually as a readonly workspace viewer — name and masked value now render consistently at full opacity, still non-editable.
Checklist