Skip to content

fix(secrets): keep readonly secret names legible instead of dimming them#4942

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/secret
Jun 10, 2026
Merged

fix(secrets): keep readonly secret names legible instead of dimming them#4942
waleedlatif1 merged 2 commits into
stagingfrom
fix/secret

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Readonly viewers saw a workspace secret's name at opacity-50 while the masked value next to it rendered at full opacity — an inconsistent, hostile treatment of content they need to read.
  • Dropped the opacity dim on the non-renameable key field; non-editability is already conveyed by the read-only field and the absent Trash/rename affordances.
  • The secret detail page was already correct (read-only fields at full opacity, copyable key), so this brings the list in line with it.

Type of Change

  • Bug fix

Testing

Tested manually as a readonly workspace viewer — name and masked value now render consistently at full opacity, still non-editable.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Readonly viewers saw the workspace secret name at opacity-50 while the
masked value rendered at full opacity, an inconsistent and hostile
treatment of content they need to read. Drop the opacity dim on the
non-renameable key; non-editability is already conveyed by the read-only
field and absent edit affordances.
@vercel

vercel Bot commented Jun 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jun 10, 2026 5:47am

Request Review

@cursor

cursor Bot commented Jun 10, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single CSS class change on a read-only input; no permission or data-handling logic touched.

Overview
Read-only workspace viewers no longer see workspace secret names dimmed at half opacity in the secrets list.

WorkspaceVariableRow updates the key ChipInput styling when canRename is false: it drops opacity-50 and cursor-not-allowed, using cursor-text instead so names match the full-opacity masked value beside them. Rename/delete restrictions are unchanged (readOnly, focus guard, missing trash).

Reviewed by Cursor Bugbot for commit f9e85bf. Configure here.

@greptile-apps

greptile-apps Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes opacity-50 from the read-only secret name field in the workspace secrets list, so the key name renders at the same full opacity as the masked value beside it. The cursor-not-allowed is replaced with cursor-text to signal that the text is selectable/copyable even though it isn't editable.

  • The single-line class change in WorkspaceVariableRow drops opacity-50 cursor-not-allowed in favor of just cursor-text when canRename is false, bringing the list row in line with the detail page which already renders read-only fields at full opacity.
  • No logic or data-flow changes are made; the field remains readOnly and all rename/delete affordances are still hidden for viewers.

Confidence Score: 5/5

Safe to merge — a single Tailwind class swap with no logic changes, no data-flow impact, and no security implications.

The change is a one-line CSS class update on a purely presentational read-only field. It removes a visual inconsistency without touching any state, permissions logic, or API calls. The field remains non-editable for viewers; only the cursor style and opacity change.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/settings/components/secrets/components/secrets-manager/secrets-manager.tsx Removes opacity-50 cursor-not-allowed from the read-only key name field and replaces it with cursor-text, fixing the visual inconsistency where the secret name was dimmed while the masked value rendered at full opacity.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[WorkspaceVariableRow renders] --> B{canRename?}
    B -- Yes --> C[ChipInput: no extra className\neditable, cursor-default]
    B -- No --> D["ChipInput: className='cursor-text'\nreadOnly, full opacity\ntext is selectable/copyable"]
    D --> E[No opacity-50 dim\nNo cursor-not-allowed]
Loading

Reviews (2): Last reviewed commit: "fix(secrets): use cursor-text on readonl..." | Re-trigger Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit f9e85bf. Configure here.

@waleedlatif1 waleedlatif1 merged commit 29ee6a7 into staging Jun 10, 2026
10 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/secret branch June 10, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant