SEC harden get_tree loaded types - #547
Merged
adrinjalali merged 5 commits intoSep 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unexpected Node initializers execute before the new type guard rejects them, leaving avoidable security and resource-exhaustion exposure.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds child-node type restrictions to reduce unsafe deserialization paths.
Changes:
- Adds
allowed_typesvalidation toget_tree. - Applies validation across general, NumPy, sklearn, and legacy loaders.
- Adds malformed-file regression tests and changelog documentation.
| File | Description |
|---|---|
skops/io/_audit.py |
Implements allowed node-type validation. |
skops/io/_general.py |
Restricts expected general child nodes. |
skops/io/_numpy.py |
Restricts NumPy child nodes. |
skops/io/_sklearn.py |
Restricts sklearn child nodes. |
skops/io/old/_numpy_v1.py |
Hardens the protocol-1 loader. |
skops/io/tests/test_audit.py |
Tests current-protocol validation. |
skops/io/tests/test_persist_old.py |
Tests legacy validation. |
docs/changes.rst |
Documents deserialization hardening. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #222
Wherever it makes sense, make sure the
get_treechecks the loaded type is actually what's expected.