FEAT support circular pointers - #549
Merged
adrinjalali merged 6 commits intoSep 29, 2026
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new circular schema remains protocol 2, allowing released readers to accept files they cannot construct.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds circular-reference persistence, enabling SciPy distributions and fitted Birch models to round-trip correctly.
Changes:
- Detects and reconstructs supported circular object graphs.
- Prevents recursion during auditing and visualization.
- Adds regression, compatibility, and corruption tests.
| File | Description |
|---|---|
skops/io/_audit.py |
Safely constructs recursive nodes. |
skops/io/_general.py |
Builds mutable containers in place. |
skops/io/_sklearn.py |
Enables Birch persistence. |
skops/io/_utils.py |
Detects circular references while saving. |
skops/io/_visualize.py |
Marks and stops at circular nodes. |
skops/io/tests/_utils.py |
Handles cycles in equality helpers. |
skops/io/tests/test_audit.py |
Tests recursive-node auditing. |
skops/io/tests/test_persist.py |
Tests circular-reference round trips. |
skops/io/tests/test_persist_old.py |
Tests collision-free downgraded IDs. |
skops/io/tests/test_visualize.py |
Tests circular visualization. |
docs/changes.rst |
Documents the new support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #184 and
Birch, supporting circular imports.