FIX a raising reduce shouldn't make dump fail - #550
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The changelog contains an inaccurate universal claim and an unresolved PR placeholder.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Prevents serialization failures when an object’s __reduce__ raises by falling back to state-based persistence.
Changes:
- Handles exceptions from
__reduce__. - Adds synthetic and pandas regression tests.
- Documents the fix for v0.17.
| File | Description |
|---|---|
skops/io/_general.py |
Adds fallback behavior for raising __reduce__. |
skops/io/tests/test_persist.py |
Adds regression coverage. |
docs/changes.rst |
Adds the v0.17 changelog entry. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically, some cython ctypes might have a raising
__reduce__.