Skip to content

Use individual members in CODEOWNERS file #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jozefizso wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use individual members in CODEOWNERS file #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,7 @@
* @slidoapp/team-presentations
# markdown-cli tool code owners

# Source code is owned by @slidoapp/team-presentations team
* @DominikPalo @jozefizso @m-kovac @filipbodor

@lakeron lakeron Oct 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better to use team handle, expect specific team member handle?

@jozefizso jozefizso Oct 24, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the @slidoapp/team-presentations team is private, we cannot use it anyway.

There's also UX problem on GitHub when teams are owners as only the team will be tagged for PR review and if we need multiple approvals, only the first team member doing the approval will be listed in the Reviewers. All the other members will not see the PR as required anymore.


# CODEOWNERS definitions are owned by admins from @slidoapp/team-presentations-admins team
.github/CODEOWNERS @DominikPalo @jozefizso