Skip to content

chore(language-server): integrate LS - #7134

Open
team-ide-user wants to merge 1 commit into
mainfrom
chore/automatic-upgrade-of-ls
Open

chore(language-server): integrate LS#7134
team-ide-user wants to merge 1 commit into
mainfrom
chore/automatic-upgrade-of-ls

Conversation

@team-ide-user

@team-ide-user team-ide-user commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Changes since last integration of Language Server

commit a99d4cf1c3e77ab6374bbe3729fcbd8b4061df9b
Author: Ben Durrans <Benjamin.Durrans@snyk.io>
Date:   Fri Aug 14 17:46:57 2026 +0100

    feat: filter files with GAF's configuration-driven file filter [CLI-1721] (#1410)
    
    * feat: filter files with GAF's configuration-driven file filter [CLI-1721]
    
    Snyk Code scans skipped files that .gitignore lists but git tracks, because the
    file filter treated every ignore rule as authoritative regardless of what is in
    the index. GAF's file filter fixes this behind FF_GITIGNORE_RESPECT_TRACKED_FILES.
    
    Scanning now dispatches per folder: with the flag on, the filter is built from a
    configuration clone carrying the folder's organization and both file filter flag
    values, so GAF resolves nothing over the network mid-scan. With the flag off, the
    previous implementation runs unchanged — it is the control arm of the rollout and
    the rollback target.
    
    Both flags and the organization are read from the folder config the scan already
    carries. Resolving any of them by path builds a fresh folder config, which opens
    the repository with go-git to enrich it and writes it back to storage, so a scan
    would otherwise repeat that work per flag — on the legacy path too, where the
    flags cannot change what the filter does. A missing folder config is refused
    rather than defaulted, because reading its flags as off would filter the folder
    as though the rollout had never reached it.
    
    Requires GAF v0.14.1: v0.11.0 exports the configuration keys but does not read
    FF_GITIGNORE_RESPECT_TRACKED_FILES in its file filter.
    
    * docs(code): tighten file filtering comments per review

M	go.mod
M	go.sum
M	infrastructure/code/code.go
A	infrastructure/code/code_file_filter_test.go
M	infrastructure/code/code_test.go
M	infrastructure/featureflag/featureflag.go
M	infrastructure/featureflag/featureflag_test.go

commit cfd689beeddbb995cef649c41f667e0356281872
Author: Ben Durrans <Benjamin.Durrans@snyk.io>
Date:   Fri Aug 14 16:26:59 2026 +0100

    ci: enable Remy Open Source fixes [AG-387] (#1407)
    
    Opt the existing ProdSec security scan into agentic SCA remediation after a blocking gate result. Keep the current severity threshold, exclusions, and runtime contexts unchanged.
    
    Co-authored-by: Cursor Agent <cursoragent@cursor.com>

M	.circleci/config.yml

commit 1bfa374c59a4211e4c2d7348a707249bfc14e1f9
Author: Ben Durrans <Benjamin.Durrans@snyk.io>
Date:   Fri Aug 14 15:57:37 2026 +0100

    refactor: resolve GAF config keys from a list (#1409)
    
    The feature flag service resolved exactly one GAF configuration key, and did so
    through a name comparison in the middle of the per-flag fetch loop. Adding a
    second key meant adding a second branch.
    
    Flags whose value comes from a GAF configuration key are now listed in
    gafConfigResolvedFlags and resolved together by getConfigValues, separate from
    the flags the feature flag service resolves by platform name. The keys share one
    configuration clone: GAF caches a batched flag evaluation on the configuration
    object it is handed, so reading them from the same clone costs one request
    between them rather than one each. A key that cannot be resolved is reported as
    false alongside a joined error, so a failed lookup can never be mistaken for an
    enabled flag.
    
    No behaviour change: ignore_workflow.ConfigIgnoreApprovalEnabled is the same
    string as the IgnoreApprovalEnabled constant it replaces, so the key written to
    folder config is unchanged.

M	infrastructure/featureflag/featureflag.go
M	infrastructure/featureflag/featureflag_test.go

@team-ide-user
team-ide-user requested a review from a team as a code owner August 14, 2026 15:03
@snyk-io

snyk-io Bot commented Aug 14, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️

"chore: automatic integration of language server a99d4cf1c3e77ab6374bbe3729fcbd8b4061df9b" is too long. Keep the first line of your commit message under 72 characters.

Generated by 🚫 dangerJS against 7f0efa4

@snyk-pr-review-bot

This comment has been minimized.

@team-ide-user
team-ide-user force-pushed the chore/automatic-upgrade-of-ls branch from 4278504 to 2d32037 Compare August 14, 2026 15:33
@snyk-pr-review-bot

This comment has been minimized.

@team-ide-user
team-ide-user force-pushed the chore/automatic-upgrade-of-ls branch from 2d32037 to 7f0efa4 Compare August 14, 2026 16:54
@snyk-pr-review-bot

Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected
📚 Repository Context Analyzed

This review considered 4 relevant code sections from 4 files (average relevance: 1.00)

🤖 Repository instructions applied (from AGENTS.md)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant