feat: wire live Configuration into analytics instrumentation - #7142
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This comment has been minimized.
This comment has been minimized.
robertolopezlopez
requested changes
Aug 18, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
robertolopezlopez
approved these changes
Aug 18, 2026
Populate REDACTION_TERMS from the live Configuration instead of a static snapshot, resolving ORGANIZATION_SLUG for redaction sweeps at teardown so it reflects the org actually used by the invoked command.
nick-y-snyk
force-pushed
the
feat/analytics-configuration-redaction
branch
from
August 18, 2026 13:59
8ed63d3 to
ef3bfd9
Compare
nick-y-snyk
enabled auto-merge
August 18, 2026 14:00
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configurationthrough toanalytics.WithConfigurationat the report-analytics chokepoint (GAF#704), sologging.REDACTION_TERMS-based scrubbing covers the CLI's own analytics extension data, not just debug logs.populateRedactionTermsexcludes the client machine id and any detected AI agent name from its unknown-value sweep — both echo a raw env var value verbatim into an extension (studio::client_machine_id,persona.agent), so without the exclusion the scrub chokepoint stripped them right back out as if they were unrecognized secrets.Squashed recreation of #7133 into a single commit (that PR had accumulated several unsquashed merge commits flagged by Danger). Same diff, same review comments should still apply — #7133 left open, not closed automatically.
Test plan
go build ./...(cliv2)go vet ./...golangci-lint run ./pkg/core/...go test ./pkg/core/...— full suite green, including newTest_populateRedactionTerms_excludesClientMachineId,Test_populateRedactionTerms_excludesDetectedAgent, and extendedTest_sendInstrumentation_passesEngineConfigurationToInstrumentationObjectGOMODCACHEresolvesgo-application-framework v0.15.0from scratch (addresses stale "unresolvable dependency" review comment on feat: wire live Configuration into analytics instrumentation #7133)