Adopt configurable Action Cable server#9
Open
samuel-williams-shopify wants to merge 1 commit into
Open
Conversation
Assisted-By: devx/edbcc7bd-6e27-4da8-bd2e-43c275487564
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This builds on the proposed Rails server configuration hook in rails/rails#57803. Instead of inserting
Async::Cable::Middlewareinto the Rails middleware stack whileActionCable.serverremains a defaultActionCable::Server::Base, this configures Action Cable itself to use an async server implementation.That keeps the mounted Rack endpoint,
ActionCable.server.broadcast, remote connections, pub/sub, heartbeat state, and channel internals on the same server object.Changes
Async::Cable::Server, a subclass ofActionCable::Server::Basethat handles Rack WebSocket requests withasync-websocket.#executorto useAsync::Cable::Executor.app.config.action_cable.server = Async::Cable::Serverbefore Action Cable copies Rails config.Async::Cable::Middlewareavailable for compatibility, but no longer use it in the Railtie path.samuel-williams-shopify/rails, branchaction-cable-configurable-server, so CI can exercise the pending Rails hook.Verification
bundle exec susbundle exec rubocopbundle exec bake covered:validatebundle exec bake decode:index:coverage libDepends on rails/rails#57803.