Minor fixes to let's encrypt environment#355
Open
ayushn21 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a couple of issues trying to deploy a Rack app using Falcon Virtual secured with a Let's Encrypt certificate.
Falcon::Environment::TLSmodule needs to be separately included in addition toFalcon::Environment::LetsEncryptTLS.I think this is a bit fiddly, and the docs don't mention this additional
includeanywhere. I've included theTLSmodule in theLetsEncryptTLSmodule so just a single include in the configuration is enough.OpenSSL::PKey::PKeyError: incorrect pkey type: id-ecPublicKeyI fixed this by adding the below line to my config:
ssl_private_key { OpenSSL::PKey.read(File.read(ssl_private_key_path)) }This PR changes the
TLSenvironment to useOpenSSL::PKey.readto fix this issue.Types of Changes
Contribution