Hotfix/failing sim tests in ci - #41
Merged
ch-ahindura merged 2 commits intoAug 7, 2026
Merged
Conversation
quantify-core's `set_datadir` does a non-recursive `os.mkdir`, so pointing it at a directory whose *parent* does not exist yet dies with a FileNotFoundError naming the child rather than the missing parent. A driver defaulting to `./bin/data` in a checkout where nothing has run `make build` never starts. It hid locally because `bin/` is left behind by any earlier build, and `mkdir` only needs the parent: removing `bin/data` alone still passes. CI has no `bin/` at all, which is where `make test-py-loop` failed — 4 failed, 34 errors, every one of them the quantify half of the parametrised loop. The qblox half passes because that tuner sets no data directory. Fixed in `compat/quantify`, which is the seam both the tuner and the executor already import `set_datadir` through, and whose job is smoothing over exactly this kind of edge. The not-installed stub keeps its no-op behaviour.
A patch: the release carries one fix, to the quantify data directory's parents. Every component that declares a version: - qpi-ui (main.go, the dashboard's package.json, the WiX installer manifest) - qpi-driver py, js and the Go CLI's Version var - qpi-client py and js The Python packages read their version from installed metadata and fall back to a literal, so the literal moves too — and with it the two tests that assert the fallback path by patching metadata to raise. Five lockfiles regenerated. The README's release URLs move as well; they 404 until the tag exists. Makefile's VERSION is bumped for consistency but referenced nowhere else in it. Not verified by a test run, at the author's request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The GitHub actions were failing to run and push the new release
Fixed
qpi-driver/py: aquantifytuner or executor creates its data directory's parents.quantify-core's own
mkdiris not recursive, sobin/datain a fresh checkoutfailed at construction.