test: add BuildFlavorVersion unit tests - #503
Merged
Merged
Conversation
freggy
reviewed
Sep 22, 2026
freggy
reviewed
Sep 22, 2026
Member
|
thank you very much for your contribution @ktrubilo9! :) I reviewed your PR and left some comments. |
freggy
requested changes
Sep 22, 2026
Contributor
Author
|
Thanks for review, I've addressed both comments, replaced the helper with test.CreateTarGz and added comparisions againts xxh3 hashes of the file contents. Also fixed the lint issue. |
freggy
approved these changes
Sep 22, 2026
Member
|
great, thanks! i'll merge once ci passes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests for BuildFlavorVersion.
The test verify that:
Also adds a small test helper for creating in-memory tar.gz changeset used by the hash computation path.
Testing
go test ./controlplane/chunk -run TestBuildFlavorVersion -count=1 -v
Closes #487