refactor(file-search): replace heavyweight workspace index - #105
Merged
Conversation
danielkov
enabled auto-merge (squash)
September 4, 2026 22:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
fff-searchwith an in-memory workspace file list built byignoreand fuzzy-matched byneo_frizbee. Prune Git metadata before traversal and report scan failures rather than returning silently incomplete results.Motivation
Workspace filename search does not need the removed backend's database, Git bindings, or file-watching dependencies. This removes 48 locked packages; both replacement crates remain at their previously locked versions, with no newly selected package versions.
Impact
Search remains capped at 100 results with UTF-8-safe highlighting. Empty queries return alphabetically sorted paths; nonempty queries use the new matcher's ranking and typo tolerance, so result order can differ. Filesystem roots are rejected, and traversal or ignore-rule errors now fail the scan explicitly.
Technical details
File discovery
Walk the workspace in parallel while honoring ignore rules and avoiding symlink traversal. Include hidden files in Git workspaces and exclude
.gitentries before descent.Match highlighting
Rank the file list first, then obtain character indices for the top candidates and convert them into merged UTF-8 byte ranges.