[WIP] qml coincontrol - #10956
Draft
accumulator wants to merge 9 commits into
Draft
[WIP] qml coincontrol#10956accumulator wants to merge 9 commits into
accumulator wants to merge 9 commits into
Conversation
…s CoinFilter. Currently, the code for coin control is separate from frozen addresses/coins, and an active coin control selection must be filtered against the frozen list by the caller the moment the selection is used. This commit is an attempt to unify the filtering, so filtering works in predictable ways everywhere (and can e.g. be more easily be extended in the future, if needed) a CoinFilter instance is owned by each wallet, and takes care of managing the list of frozen coins/addresses and the coin control set. Upon query, additional filters like nonlocal_only, confirmed_only are applied.
- select coins/addresses in the address & coin list and add/remove them from coin control - highlight coins that are in coin control (CoinDelegate + ItemDelegateBackground) - expose coinsInCoinControl on QEWallet and surface an active-coin-control indicator in the header tag and the confirm-tx dialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements coincontrol for QML client.
builds on #10918