commands: add dscancel command, analog to bumpfee - #11005
Open
devdavidejesus wants to merge 1 commit into
Open
devdavidejesus wants to merge 1 commit into
devdavidejesus wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8268.
Exposes
wallet.dscancelon the CLI/RPC, following the existingbumpfeecommand as suggested in the issue. It accepts a raw tx or a txid (which must already be in the wallet history),new_fee_ratein sat/vbyte, and--unsigned/--password.Tests:
test_dscancelintests/test_commands.py, reusing thetest_bumpfeefixture. It covers the signed replacement (same input, a single output back to the wallet), the unsigned PSBT, rejection when the new fee rate is not higher than the old one, and the txid path with and without the tx in the wallet db.cpfpis left out to keep this focused; happy to add it in a separate PR if wanted.