commands: clear error for malformed decimal CLI arguments - #11006
Open
devdavidejesus wants to merge 1 commit into
Open
devdavidejesus wants to merge 1 commit into
devdavidejesus wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7404.
Command-line arguments typed as decimal (
decimal,decimal_or_dryrun,decimal_or_maxinarg_types) were converted with lambdas that raisedecimal.InvalidOperationon malformed input. argparse only turnsArgumentTypeError,TypeErrorandValueErrorfrom a type function into a usage error, so any malformed amount crashed with a traceback. This affects every command with a decimal argument, not onlyadd_request(e.g.payto <address> abc).The conversion now goes through a small helper that raises
argparse.ArgumentTypeError:The special values (
!for max,dryrun) are handled as before. Test:test_cli_decimal_args_reject_malformed_valuesintests/test_commands.py.