feat: Simplify filter decorator with pass_build_env option#23
Merged
Conversation
The @filter decorator now supports a pass_build_env parameter. When set to True, the filter receives BuildEnvironment as its first argument, eliminating the need for factory functions. Co-authored-by: MiMoCode <mimo@xiaomi.com>
SilverRainZ
force-pushed
the
feat/simplify-filter-decorator
branch
from
fc18329 to
7e6a838
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@filterdecorator by adding apass_build_envparameterpass_build_env=True, the filter receivesBuildEnvironmentas its first argumentChanges
JinjaRegistryto store(func, needs_env)tuples instead of factory functionspass_build_envparameter to@filterdecorator_JinjaEnvto inject environment whenpass_build_env=Trueroles,jsonify,catify) to new APIpass_build_envusageTesting