Skip to content

Add a VoteDeclined event to ProposalEvent - #43

Closed
geffrak wants to merge 1 commit into
mainfrom
geffrak/13126852513-vote-declined-event
Closed

geffrak wants to merge 1 commit into
mainfrom
geffrak/13126852513-vote-declined-event

Conversation

@geffrak

@geffrak geffrak commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Ticket: https://splitsecure.monday.com/boards/8107294006/pulses/13126852513

Problem

A device can now decline a threshold proposal. The server records the decline as its own proposal event, so that a decline never counts toward the threshold. ProposalEvent has no event for it, so the server carries the message in a local copy of this file.

Fix

Add VoteDeclined { vote_bottle = 1; voter_enclave_id = 2; } to ProposalEvent, at oneof tag 11. It has the same shape as VoteReceived. Additive.

Validation

buf lint clean. buf breaking against main clean. Go and TS regenerated.

@github-actions

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 24, 2026, 3:28 PM

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: splitsecure/apis/.coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 5f1e42f3-14ef-4220-9fb8-eb1640ab316e

📥 Commits

Reviewing files that changed from the base of the PR and between 039ca33 and 4888066.

⛔ Files ignored due to path filters (2)
  • gen/es/proto/splitsecure/proposals/v1/events_pb.ts is excluded by !**/gen/**, !gen/**
  • gen/go/proto/splitsecure/proposals/v1/events.pb.go is excluded by !**/*.pb.go, !**/gen/**, !gen/**
📒 Files selected for processing (1)
  • proto/splitsecure/proposals/v1/events.proto

Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: Check Generated Code
🔇 Additional comments (1)
proto/splitsecure/proposals/v1/events.proto (1)

22-22: LGTM!

Also applies to: 39-45


Walkthrough

The proposal event oneof adds a vote-decline variant. Its nested message contains a vote bottle and voter enclave ID. Comments state that a decline does not count toward the threshold and that its bottle contains no share material.

Changes

Vote decline event

Layer / File(s) Summary
Add the vote-decline event contract
proto/splitsecure/proposals/v1/events.proto
Adds vote_declined as oneof field 11 and defines VoteDeclined with vote_bottle and voter_enclave_id fields. Comments describe the decline event and its bottle.
Estimated code review effort: 1 (Trivial) ~3 minutes

Merge Risk: ⚪ Minimal · up to 48880

This change adds a vote-decline event type and generated bindings. No concrete merge-blocking issue is established by the repository evidence.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding a VoteDeclined event to ProposalEvent.
Description check ✅ Passed The description explains the problem, the schema change, the event behavior, and validation results. It is directly related to the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@geffrak geffrak closed this Sep 24, 2026
@geffrak
geffrak deleted the geffrak/13126852513-vote-declined-event branch September 24, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant