Repository navigation
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: splitsecure/apis/.coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🔇 Additional comments (1)
WalkthroughThe proposal event oneof adds a vote-decline variant. Its nested message contains a vote bottle and voter enclave ID. Comments state that a decline does not count toward the threshold and that its bottle contains no share material. ChangesVote decline event
Merge Risk: ⚪ Minimal · up to This change adds a vote-decline event type and generated bindings. No concrete merge-blocking issue is established by the repository evidence. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
Ticket: https://splitsecure.monday.com/boards/8107294006/pulses/13126852513
Problem
A device can now decline a threshold proposal. The server records the decline as its own proposal event, so that a decline never counts toward the threshold.
ProposalEventhas no event for it, so the server carries the message in a local copy of this file.Fix
Add
VoteDeclined { vote_bottle = 1; voter_enclave_id = 2; }toProposalEvent, at oneof tag 11. It has the same shape asVoteReceived. Additive.Validation
buf lintclean.buf breakingagainstmainclean. Go and TS regenerated.