Return nonzero status on CLI inference failure#197
Draft
dissonancehelix wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
predict.main()return0after successful inference.1from both handled inference-error paths.predict.pyis executed directly.Why
The CLI currently catches
IOErrorand general inference exceptions, prints an error, and then completes without a failing process status. Automation can therefore treat a failed transcription as successful.The existing error output and traceback are preserved; this change only makes the process status match the reported outcome.
Validation
Added deterministic CLI-contract tests with the model and inference call replaced by fakes:
The tests verify status
0after success and status1after a handled inference failure. They do not load a model or process audio.