Conversation
Pass null for privateKeyType in the four-argument factory so the PEM private key is not stored as the key type, which broke getPrivateKeySpec(). Fixes spring-projects#1047 Signed-off-by: arimu1 <19286898+arimu1@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CertificateBundle.of(String, String, String, String)factory so it passesnullforprivateKeyTypeinstead of duplicating the PEM private key string.CertificateBundleUnitTeststo assertgetPrivateKeyType()is null for the four-arg factory and that the five-arg overload still parses RSA keys correctly.Problem
The four-arg
of()method incorrectly passedprivateKeyas both the private key andprivateKeyTypeconstructor arguments. Callers that later invokedgetPrivateKeySpec()hitIllegalArgumentExceptionbecause the key type was PEM material rather thanrsaorec.Test plan
mvn -pl spring-vault-core -am test -Dtest=CertificateBundleUnitTests -DfailIfNoTests=false(Temurin 21)Fixes #1047