Development - #298
Merged
Merged
Development#298
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new plot_double_pendulum() roxygen example isn’t guarded for ggplot2, which can cause R CMD check example failures when optional packages aren’t installed.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a new continuous-time “double pendulum” trajectory generator to RandomWalker (Fixes #287), along with visualization helpers and updated package documentation/site outputs.
Changes:
- Introduces
double_pendulum_walk()plusplot_double_pendulum()/animate_double_pendulum()for trajectory plotting/animation (optional deps). - Updates package metadata/exports and documentation (README, vignette, man pages, NEWS).
- Regenerates pkgdown site content to include the new vignette/reference pages and navigation entries.
File summaries
| File | Description |
|---|---|
| DESCRIPTION | Adds optional Suggests + roxygen version bump |
| NAMESPACE | Exports new pendulum functions; imports .data |
| NEWS.md | Announces double-pendulum feature (Fix #287) |
| R/00_global_variables.R | Adds .env to silence check notes |
| R/gen-double-pendulum.R | Implements double_pendulum_walk() generator |
| R/plt-double-pendulum.R | Implements plot + animation helpers |
| README.Rmd | Adds double-pendulum quick-start section |
| README.md | Generated README with double-pendulum section |
| vignettes/basic-concepts.Rmd | Minor vignette edits (tibble construction) |
| vignettes/double-pendulum.Rmd | New vignette describing model/usage |
| man/animate_double_pendulum.Rd | Generated docs for animation helper |
| man/brownian_motion.Rd | Adds pendulum to “See also” |
| man/custom_walk.Rd | Adds pendulum to “See also” |
| man/discrete_walk.Rd | Adds pendulum to “See also” |
| man/double_pendulum_walk.Rd | Generated docs for generator |
| man/geometric_brownian_motion.Rd | Adds pendulum to “See also” |
| man/plot_double_pendulum.Rd | Generated docs for plot helper |
| man/random_beta_walk.Rd | Adds pendulum to “See also” |
| man/random_binomial_walk.Rd | Adds pendulum to “See also” |
| man/random_cauchy_walk.Rd | Adds pendulum to “See also” |
| man/random_chisquared_walk.Rd | Adds pendulum to “See also” |
| man/random_displacement_walk.Rd | Adds pendulum to “See also” |
| man/random_exponential_walk.Rd | Adds pendulum to “See also” |
| man/random_f_walk.Rd | Adds pendulum to “See also” |
| man/random_gamma_walk.Rd | Adds pendulum to “See also” |
| man/random_geometric_walk.Rd | Adds pendulum to “See also” |
| man/random_hypergeometric_walk.Rd | Adds pendulum to “See also” |
| man/random_logistic_walk.Rd | Adds pendulum to “See also” |
| man/random_lognormal_walk.Rd | Adds pendulum to “See also” |
| man/random_multinomial_walk.Rd | Adds pendulum to “See also” |
| man/random_negbinomial_walk.Rd | Adds pendulum to “See also” |
| man/random_normal_drift_walk.Rd | Adds pendulum to “See also” |
| man/random_normal_walk.Rd | Adds pendulum to “See also” |
| man/random_poisson_walk.Rd | Adds pendulum to “See also” |
| man/random_smirnov_walk.Rd | Adds pendulum to “See also” |
| man/random_t_walk.Rd | Adds pendulum to “See also” |
| man/random_uniform_walk.Rd | Adds pendulum to “See also” |
| man/random_weibull_walk.Rd | Adds pendulum to “See also” |
| man/random_wilcox_walk.Rd | Adds pendulum to “See also” |
| man/random_wilcoxon_sr_walk.Rd | Adds pendulum to “See also” |
| man/visualize_walks.Rd | Links pendulum viz helpers in “See also” |
| tests/double-pendulum.R | Adds non-testthat regression tests for feature |
| _pkgdown.yml | Adds navbar entry for new article |
| docs/404.html | Regenerated site page with new navbar + deps |
| docs/LICENSE-text.html | Regenerated site page with new navbar + deps |
| docs/LICENSE.html | Regenerated site page with new navbar + deps |
| docs/WIKI_SUMMARY.html | Regenerated wiki summary + new article link |
| docs/articles/automatic-random-walks.html | Regenerated article (navbar/deps) |
| docs/articles/continuous-distribution-generators.html | Regenerated article (navbar/deps) |
| docs/articles/double-pendulum.html | Generated new HTML article |
| docs/articles/double-pendulum.md | Generated new article markdown |
| docs/articles/getting-started.html | Regenerated article (navbar/deps) |
| docs/articles/getting-started.md | Regenerated article markdown |
| docs/articles/home.html | Regenerated article (navbar/deps) |
| docs/articles/home.md | Regenerated article markdown |
| docs/articles/index.md | Adds double-pendulum article to list |
| docs/authors.md | Updates generated citation year |
| docs/copilot-instructions.html | Regenerated page (navbar/deps) |
| docs/copilot-instructions.md | Regenerated page markdown |
| docs/deps/bootstrap-5.3.8/font.css | Adds new bootstrap font asset |
| docs/deps/data-deps.txt | Updates bootstrap dependency references |
| docs/index.md | Generated homepage adds pendulum section |
| docs/index.html | Regenerated homepage HTML (pendulum section) |
| docs/llms.txt | Regenerated LLM/site summary content |
| docs/news/index.md | Regenerated NEWS page markdown |
| docs/pkgdown.yml | Regenerated pkgdown metadata + new article |
| docs/reference/animate_double_pendulum.html | Generated reference HTML |
| docs/reference/animate_double_pendulum.md | Generated reference markdown |
| docs/reference/confidence_interval.md | Regenerated reference output |
| docs/reference/cgmean.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/chmean.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/ckurtosis.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/cmean.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/cmedian.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/crange.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/crange.md | Minor formatting regen |
| docs/reference/csd.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/cvar.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/custom_walk.md | Regenerated reference markdown |
| docs/reference/discrete_walk.md | Regenerated reference markdown |
| docs/reference/double_pendulum_walk.html | Generated reference HTML |
| docs/reference/double_pendulum_walk.md | Generated reference markdown |
| docs/reference/euclidean_distance.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/get_attributes.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/index.md | Adds pendulum items to reference index |
| docs/reference/kurtosis_vec.md | Fixes/updates displayed formula |
| docs/reference/name.md | Minor formatting regen |
| docs/reference/plot_double_pendulum-1.png | Generated reference figure asset |
| docs/reference/plot_double_pendulum.html | Generated reference HTML |
| docs/reference/plot_double_pendulum.md | Generated reference markdown |
| docs/reference/rand_walk_column_names.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/rand_walk_helper.md | Regenerated reference output |
| docs/reference/random_binomial_walk.md | Regenerated reference markdown |
| docs/reference/random_displacement_walk.md | Regenerated reference markdown |
| docs/reference/random_geometric_walk.md | Regenerated reference markdown |
| docs/reference/random_hypergeometric_walk.md | Regenerated reference markdown |
| docs/reference/random_lognormal_walk.md | Regenerated reference markdown |
| docs/reference/random_logistic_walk.md | Regenerated reference markdown |
| docs/reference/random_multinomial_walk.md | Regenerated reference markdown |
| docs/reference/random_negbinomial_walk.md | Regenerated reference markdown |
| docs/reference/random_poisson_walk.md | Regenerated reference markdown |
| docs/reference/random_smirnov_walk.md | Regenerated reference markdown |
| docs/reference/random_wilcox_walk.md | Regenerated reference markdown |
| docs/reference/random_wilcoxon_sr_walk.md | Regenerated reference markdown |
| docs/reference/running_quantile.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/rw30.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/rw_range.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/skewness_vec.md | Fixes/updates displayed formula |
| docs/reference/std_cum_max_augment.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/std_cum_mean_augment.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/std_cum_min_augment.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/std_cum_prod_augment.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/std_cum_sum_augment.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/subset_walks.html | Regenerated reference HTML (navbar/deps) |
| docs/reference/libs/ggiraphjs-0.9.4/girafe.yaml | Adds ggiraphjs widget metadata |
| docs/reference/libs/liberation-mono-0.5.1/css/liberation-mono.css | Adds font CSS asset |
| docs/reference/libs/liberation-mono-0.5.1/fonts/AUTHORS | Adds font license metadata |
| docs/reference/libs/liberation-mono-0.5.1/fonts/ChangeLog | Adds font changelog |
| docs/reference/libs/liberation-mono-0.5.1/fonts/LICENSE | Adds font license text |
| docs/reference/libs/liberation-mono-0.5.1/fonts/README | Adds font README |
| docs/reference/libs/liberation-mono-0.5.1/fonts/TODO | Adds font TODO file |
| docs/reference/libs/liberation-sans-0.5.1/css/liberation-sans.css | Adds font CSS asset |
| docs/reference/libs/liberation-sans-0.5.1/fonts/AUTHORS | Adds font license metadata |
| docs/reference/libs/liberation-sans-0.5.1/fonts/ChangeLog | Adds font changelog |
| docs/reference/libs/liberation-sans-0.5.1/fonts/LICENSE | Adds font license text |
| docs/reference/libs/liberation-sans-0.5.1/fonts/README | Adds font README |
| docs/reference/libs/liberation-sans-0.5.1/fonts/TODO | Adds font TODO file |
| docs/reference/libs/liberation-serif-0.5.1/css/liberation-serif.css | Adds font CSS asset |
| docs/reference/libs/liberation-serif-0.5.1/fonts/AUTHORS | Adds font license metadata |
| docs/reference/libs/liberation-serif-0.5.1/fonts/ChangeLog | Adds font changelog |
| docs/reference/libs/liberation-serif-0.5.1/fonts/LICENSE | Adds font license text |
| docs/reference/libs/liberation-serif-0.5.1/fonts/README | Adds font README |
| docs/reference/libs/liberation-serif-0.5.1/fonts/TODO | Adds font TODO file |
| docs/sitemap.xml | Adds new article/reference URLs |
Review details
- Files reviewed: 99/428 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| #' @return A customizable ggplot of the second bob's spatial trajectory, | ||
| #' colored by elapsed seconds. Coordinates are in meters. | ||
| #' @examples | ||
| #' if (requireNamespace("deSolve", quietly = TRUE)) { |
| @@ -290,7 +290,7 @@ steps <- rnorm(100, mean = 0, sd = 1) | |||
| positions <- cumsum(c(0, steps[-100])) | |||
|
|
|||
| # 3. Add to tibble | |||
| walk_data <- tibble::tibble( | |||
| walk_data <- dplyr::tibble( | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #287