Development - #302
Merged
Merged
Development#302
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
CRAN comments appear inconsistent with the package version, and several README plot images have empty alt text, reducing accessibility.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR focuses on documentation and release-note hygiene updates for RandomWalker: refreshing community/contact information, tightening README rendering (including accessibility attributes), and trimming visualize_walks() example blocks in the generated docs.
Changes:
- Update community/contact and license links in vignettes/README content.
- Regenerate
README.mdoutput/formatting and addaltattributes to embedded images. - Remove some
visualize_walks()examples from roxygen/Rd output and adjust CRAN comments text.
File summaries
| File | Description |
|---|---|
| vignettes/faq.Rmd | Updates community link from Twitter to Telegram. |
| README.Rmd | Updates license link target used to generate README output. |
| README.md | Regenerated README output; adds alt attributes and updates license link formatting. |
| R/plt-visualize-walks.R | Removes two roxygen examples for visualize_walks(). |
| man/visualize_walks.Rd | Keeps generated Rd examples in sync with roxygen changes. |
| cran-comments.md | Updates check summary and release/version note text. |
Review details
Files not reviewed (1)
- man/visualize_walks.Rd: Generated file
Suppressed comments (2)
README.md:185
- This plot image has an empty alt attribute (alt=""), which provides no context for screen readers and differs from the descriptive alt text used earlier in the README.
<img src="man/figures/README-custom_examples-2.png" alt="" width="100%" />
README.md:246
- This plot image has an empty alt attribute (alt=""), which makes the figure inaccessible to screen readers and inconsistent with the earlier plot image that includes a descriptive alt.
<img src="man/figures/README-discrete_examples-1.png" alt="" width="100%" />
- Files reviewed: 5/10 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ``` | ||
|
|
||
| <img src="man/figures/README-custom_examples-1.png" width="100%" /> | ||
| <img src="man/figures/README-custom_examples-1.png" alt="" width="100%" /> |
| ## R CMD check results | ||
|
|
||
| 0 errors | 0 warnings | 1 note | ||
| 0 errors | 0 warnings | 2 note |
| 0 errors | 0 warnings | 2 note | ||
|
|
||
| * This is a major release 1.0.0 | ||
| * This is a minor release 1.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.