Fix: EU region URL change for NinjaOne plugin#77
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated NinjaOne regional API base URL hostnames in ChangesNinjaOne endpoint and version update
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Switches US/US2/CA/OC to the documented app./us2./ca./oc.ninjarmm.com hostnames instead of the api./-api variants, matching the same fix already applied to EU to avoid the same class of region-URL issue. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
🧩 Plugin PR Summary📦 Modified Plugins
📋 Results
🔍 Validation Details✅
|
|
Are we able to test this change with other regions or confident this will work as expected? |
|
📋 Summary
Quite a simple region change for the EU region for the NinjaOne plugin. This does not break existing EU region customers as the new/changed URL resolves to the same API. This change is needed though as some NinjaOne customers do require eu.ninjarmm.com. The existing eu-api.ninjarmm.com URL that the plugin uses is an alias that seemingly not all customers can use.
🔗 Related issue(s)
https://squaredup-eng.atlassian.net/browse/PLUG-4662
🧩 Plugin details
Does this PR introduce any breaking changes?
If yes, describe:
📚 Documentation
✅ Checklist
Summary by CodeRabbit