Skip to content

Document dependsOn/scope for dependent import steps in build-plugin skill#97

Merged
andrewmumblebee merged 3 commits into
mainfrom
work/ah/dependent-imports
Jul 21, 2026
Merged

Document dependsOn/scope for dependent import steps in build-plugin skill#97
andrewmumblebee merged 3 commits into
mainfrom
work/ah/dependent-imports

Conversation

@andrewmumblebee

@andrewmumblebee andrewmumblebee commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

📋 Summary

Adds guidance to the build-plugin skill on using dependsOn + scope on indexDefinitions steps, so an import step can wait for another step's objects to land and scope its dataStream query to them (see plugins/Sanity/v1/indexDefinitions/default.json for a real example).

  • references/index-defs.md — extends the existing worked example with a dependent step and documents scope.query, dependsOn (including multi-dependency and multi-level chains), and optional.
  • SKILL.md — Phase 2 now flags when to plan a dependent step; Phase 5 adds a conditional "one pass per dependency level" build/test loop, reusing the existing scoped-stream test procedure and Checkpoint B re-index cycle rather than introducing new mechanics.

🔍 Scope of change

  • Documentation only
  • Repository metadata or configuration
  • CI / automation
  • Other (please describe):

📚 Checklist

Summary by CodeRabbit

  • Documentation
    • Revised the Phase 5 build-plugin workflow to handle dependency-ordered import steps, repeating the import-definition/testing cycle by dependency depth.
    • Updated guidance for scoped, dependent import planning, including how scoped queries reference already-imported parents.
    • Expanded reconciliation-pass instructions to run at the end of each Phase 5 build segment and at the end of Phase 6.
    • Added an optional, scoped deviceAlerts import example and documented optional behavior (warnings instead of hard failures).

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The build-plugin guidance now covers scoped dependent imports, including planning, dependency-level testing, Checkpoint B reruns, and reconciliation. The index-definition reference adds an optional deviceAlerts step dependent on imported devices.

Changes

Dependent import workflow

Layer / File(s) Summary
Scoped dependent-step reference
.claude/skills/build-plugin/references/index-defs.md
Adds the scoped deviceAlerts example and documents scope.query, dependsOn, optional, and dependency ordering.
Dependency-aware build workflow
.claude/skills/build-plugin/SKILL.md
Updates planning and Phase 5 guidance to process root imports before dependent levels, rerun Checkpoint B between levels, and reconcile after each build and Phase 6.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main documentation update about dependsOn/scope for dependent import steps.
Description check ✅ Passed The description is relevant, structured, and includes summary, scope, and checklist information for this documentation-only change.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.claude/skills/build-plugin/references/index-defs.md:
- Around line 37-48: Update the scope.query in the installations import
definition to constrain results to device vertices, using the device-specific
discriminator/property rather than only sourceType = "Router"; preserve the
existing objectMapping, optional flag, and dependsOn configuration.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 40883316-d1c6-4de9-8b56-6b727da87d65

📥 Commits

Reviewing files that changed from the base of the PR and between 9dafcf7 and 79e4bf1.

📒 Files selected for processing (2)
  • .claude/skills/build-plugin/SKILL.md
  • .claude/skills/build-plugin/references/index-defs.md

Comment thread .claude/skills/build-plugin/references/index-defs.md
@andrewmumblebee
andrewmumblebee marked this pull request as ready for review July 21, 2026 06:55
@andrewmumblebee
andrewmumblebee requested a review from a team July 21, 2026 06:55
@github-actions

Copy link
Copy Markdown

🧩 Plugin PR Summary

ℹ️ No plugins were modified in this PR.

@andrewmumblebee
andrewmumblebee requested a review from clarkd July 21, 2026 06:56

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.claude/skills/build-plugin/SKILL.md:
- Around line 255-258: Expand the dependent-stream testing procedure in the
build-plugin skill to cover both scoped stream types: retain single-object
testing with --object for httpRequestScopedSingle, and add instructions for
httpRequestScoped streams to test the complete matched-object set and verify
{{objects}} is populated correctly. Reference the existing scoped test procedure
and index-definitions guidance without changing the dependency-level workflow.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1395480d-e210-4804-ba96-145ae4d09c32

📥 Commits

Reviewing files that changed from the base of the PR and between 79e4bf1 and c7c2455.

📒 Files selected for processing (2)
  • .claude/skills/build-plugin/SKILL.md
  • .claude/skills/build-plugin/references/index-defs.md

Comment thread .claude/skills/build-plugin/SKILL.md

@adamkinniburgh adamkinniburgh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@andrewmumblebee
andrewmumblebee merged commit 7d7b20e into main Jul 21, 2026
1 check passed
@andrewmumblebee
andrewmumblebee deleted the work/ah/dependent-imports branch July 21, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants