chore(ci): replace SourceKnight with setup-sp - #30
Open
Rushaway wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the SourceKnight-based build (
maxime1907/action-sourceknight) with a native GitHub Actions workflow usingrumblefrog/setup-sp, matching the pattern already rolled out to other srcdslab repos (e.g.sm-plugin-AdminRoom).Plugin targets
addons/sourcemod/scripting/CountryTags.spDependencies (from sourceknight.yaml)
/addons/sourcemod/scripting/include->/addons/sourcemod/scripting/include(The
sourcemoddependency wastype: tar— the SourceMod runtime itself — and is now provided byrumblefrog/setup-spat version1.12.xinstead of a downloaded tarball.)Packaging
The old workflow copied
.sourceknight/package/*plus the fullcsgo/directory (which containscsgo/addons/sourcemod/configs/countryflags.cfgandcsgo/materials/panorama/...flag images) into the release artifact. The new workflow replicates this by copying the compiled.smxintoaddons/sourcemod/plugins/and copying the contents ofcsgo/into the package root, preserving the existing configs and materials.Not locally validated
Per instructions, this migration was done without cloning dependency repos, downloading spcomp, or compiling anything locally. This PR relies on the CI run itself to confirm the build compiles successfully — no local spcomp run was performed.
Manual verification needed
MultiColorsinclude path used in the workflow (addons/sourcemod/scripting/include) matches whatsm-plugin-MultiColorsactually publishes.🤖 Generated with Claude Code