Conversation
The v11.0.0 action release failed: release-action.yml built only utils
and core, but packages/action bundles 7 workspace packages, so bun
build could not resolve @node-minify/benchmark.
error: Could not resolve: "@node-minify/benchmark"
at packages/action/src/benchmark.ts:8:27
Use the root build script, which already builds utils first, then
everything except the action in parallel, then the action last.
Verified from a clean packages/action/dist that the bundle is produced
and resolves benchmark.
* origin/main: Version Packages
|
Deploying node-minify-docs with
|
| Latest commit: |
34cde46
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0af5a0ad.node-minify-docs.pages.dev |
| Branch Preview URL: | https://develop.node-minify-docs.pages.dev |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe release workflow replaces separate dependency and action build steps with one root-level ChangesRelease workflow build
Estimated code review effort: 2 (Simple) | ~5 minutes Merge Risk: ⚪ Minimal · up to The release workflow now builds workspace dependencies before bundling the action; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2906 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 69 69
Lines 1961 1961
Branches 599 599
=======================================
Hits 1954 1954
Misses 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fix the failed v11.0.0 action release
npm publishing succeeded — all 22 packages are live at
11.0.0— but the newly-wired action release step failed on its first ever run (run 33636966534).Cause
release-action.ymlbuilt only two workspace packages:But
packages/actionbundles seven:benchmark,core,esbuild,oxc,swc,terser,utils. Sobun buildcould not resolve the rest:This was pre-existing — the workflow had never run before, so it had never been exercised.
Fix
Use the root
buildscript, which already handles ordering:utilsfirst, then everything except the action in parallel, then the action last.Verified from a clean
packages/action/dist: build exits 0,dist/index.jsis produced, and the bundle resolvesbenchmark.Consequence
v11.0.0published to npm but nov11/v11.0.0git tag exists, souses: srod/node-minify@v11still does not resolve. After this merges, re-run the workflow to create the tags:The authorization guard added in #2905 permits this:
v11.0.0is a published, non-draft release.Verification
Summary by cubic
Fixes the v11.0.0 action release failure by building all workspace packages before bundling the action.
The release workflow previously built only
utilsandcore, but the action bundles seven workspace packages, sobun buildcould not resolve@node-minify/benchmark. The rootbuildscript already handles the correct order —utilsfirst, then the other packages in parallel, then the action last — so the workflow now uses it instead of manually building two packages. Verified that the bundle is produced and resolvesbenchmarkfrom a cleanpackages/action/dist. Note thatv11.0.0was published to npm without a git tag; re-run the workflow after this merges to create thev11/v11.0.0tags.Written for commit 34cde46. Summary will update on new commits.
Summary by CodeRabbit