Skip to content

fix(ci): build all workspace deps before bundling the action - #2906

Merged
srod merged 2 commits into
mainfrom
develop
Sep 2, 2026
Merged

fix(ci): build all workspace deps before bundling the action#2906
srod merged 2 commits into
mainfrom
develop

Conversation

@srod

@srod srod commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Fix the failed v11.0.0 action release

npm publishing succeeded — all 22 packages are live at 11.0.0 — but the newly-wired action release step failed on its first ever run (run 33636966534).

Cause

release-action.yml built only two workspace packages:

bun run build:deps                          # utils
bun run --filter '@node-minify/core' build  # core

But packages/action bundles seven: benchmark, core, esbuild, oxc, swc, terser, utils. So bun build could not resolve the rest:

error: Could not resolve: "@node-minify/benchmark"
  at packages/action/src/benchmark.ts:8:27
error: script "build" exited with code 1

This was pre-existing — the workflow had never run before, so it had never been exercised.

Fix

Use the root build script, which already handles ordering: utils first, then everything except the action in parallel, then the action last.

Verified from a clean packages/action/dist: build exits 0, dist/index.js is produced, and the bundle resolves benchmark.

Consequence

v11.0.0 published to npm but no v11 / v11.0.0 git tag exists, so uses: srod/node-minify@v11 still does not resolve. After this merges, re-run the workflow to create the tags:

gh workflow run release-action.yml -f tag=v11.0.0

The authorization guard added in #2905 permits this: v11.0.0 is a published, non-draft release.

Verification

Gate Result
clean rebuild → action bundle pass
lint / typecheck pass
test 1047 passed (70 files)
removed-compressor guard pass
YAML parse pass

Summary by cubic

Fixes the v11.0.0 action release failure by building all workspace packages before bundling the action.

The release workflow previously built only utils and core, but the action bundles seven workspace packages, so bun build could not resolve @node-minify/benchmark. The root build script already handles the correct order — utils first, then the other packages in parallel, then the action last — so the workflow now uses it instead of manually building two packages. Verified that the bundle is produced and resolves benchmark from a clean packages/action/dist. Note that v11.0.0 was published to npm without a git tag; re-run the workflow after this merges to create the v11 / v11.0.0 tags.

Written for commit 34cde46. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Chores
    • Streamlined the release build process into a single consolidated build step.
    • Preserved the correct build ordering for workspace packages while bundling the action and its dependencies.

srod added 2 commits September 2, 2026 15:44
The v11.0.0 action release failed: release-action.yml built only utils
and core, but packages/action bundles 7 workspace packages, so bun
build could not resolve @node-minify/benchmark.

  error: Could not resolve: "@node-minify/benchmark"
    at packages/action/src/benchmark.ts:8:27

Use the root build script, which already builds utils first, then
everything except the action in parallel, then the action last.
Verified from a clean packages/action/dist that the bundle is produced
and resolves benchmark.
@changeset-bot

changeset-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 34cde46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying node-minify-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 34cde46
Status: ✅  Deploy successful!
Preview URL: https://0af5a0ad.node-minify-docs.pages.dev
Branch Preview URL: https://develop.node-minify-docs.pages.dev

View logs

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: efdc1571-4c7e-4cf7-bce3-4ffda5c25e23

📥 Commits

Reviewing files that changed from the base of the PR and between f1746f1 and 34cde46.

📒 Files selected for processing (1)
  • .github/workflows/release-action.yml

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The release workflow replaces separate dependency and action build steps with one root-level bun run build command. A comment documents that the command builds seven workspace packages in dependency order.

Changes

Release workflow build

Layer / File(s) Summary
Workspace-wide action build
.github/workflows/release-action.yml
The workflow consolidates dependency and action builds into one root-level bun run build step. A comment documents the workspace build ordering.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 34cde

The release workflow now builds workspace dependencies before bundling the action; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating CI to build all workspace dependencies before bundling the action.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.64%. Comparing base (f1746f1) to head (34cde46).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2906   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files          69       69           
  Lines        1961     1961           
  Branches      599      599           
=======================================
  Hits         1954     1954           
  Misses          7        7           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@srod
srod merged commit 91b60a1 into main Sep 2, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant