Van den elzen 07 02 2026#1402
Conversation
Attempted to further fill in and validate record 5503
Filled in manuscript info 5503
wlpotter
left a comment
wlpotter
left a comment
There was a problem hiding this comment.
Great work @Calvin-cmd-lgtm ! See the in-line comments for specific feedback, and let me know if I can clarify further.
| <sponsor>Syriaca.org: The Syriac Reference Portal</sponsor> | ||
| <funder>The International Balzan Prize Foundation</funder> | ||
| <funder>The National Endowment for the Humanities</funder> | ||
| <editor role="creator" ref="#crvandenelzen"></editor> |
There was a problem hiding this comment.
Don't forget to include the full editors.xml URI before your editor ID: "http://syriaca.org/documentation/editors.xml#". Compare the ref attribute in line 21.
| </langUsage> | ||
| </profileDesc> | ||
| <revisionDesc status="uncorrected-draft"> | ||
| <change who="#crvandenelzen" when="2026-07-09">Validated record.</change> |
There was a problem hiding this comment.
Here also you'll want to include the full editors URI
| <text> | ||
| <body> | ||
| <bibl xml:id="work-5503-1" type="lawd:ConceptualWork"> | ||
| <title xml:id="name-5503-1" xml:lang="en" srophe:tags="#syriaca-headword">Apology</title> |
There was a problem hiding this comment.
- The pattern for work title's xml:id should be
name5503-n, where n is the sequence number, e.g. name5503-1, name 5503-2, etc. - Work titles need either a source attribute pointing to a bibl xml:id (
source="#bib5503-1", e.g.) or aresp="http://syriaca.org"attribute
| <bibl xml:id="work-5503-1" type="lawd:ConceptualWork"> | ||
| <title xml:id="name-5503-1" xml:lang="en" srophe:tags="#syriaca-headword">Apology</title> | ||
| <title xml:id="name-5503-2" xml:lang="en" srophe:tags="#syriaca-headword">ܕܪܫܐ</title> | ||
| <author ref="http://syriaca.org/person/790" source="#bib5503-1" xml:lang="en">Timothy I — <foreign xml:lang="syr">ܛܝܡܬܐܘܣ ܩܕܡܝܐ</foreign></author> |
There was a problem hiding this comment.
Author elements also need a source or resp attribute, like with titles
| <title xml:id="name-5503-1" xml:lang="en" srophe:tags="#syriaca-headword">Apology</title> | ||
| <title xml:id="name-5503-2" xml:lang="en" srophe:tags="#syriaca-headword">ܕܪܫܐ</title> | ||
| <author ref="http://syriaca.org/person/790" source="#bib5503-1" xml:lang="en">Timothy I — <foreign xml:lang="syr">ܛܝܡܬܐܘܣ ܩܕܡܝܐ</foreign></author> | ||
| <idno type="URI">http://syriaca.org/work/5503/tei</idno> |
There was a problem hiding this comment.
The idno in the publicationStmt/idno, above should have the /tei, but the one in the main work record (body/bibl/idno) should just be "http://syriaca.org/work/5503". Recall that the teiHeader, where the publicationStmt is, describes the XML file and the URI for the file is /tei. The URI for the work itself, which is described in the body/bibl, is for the conceptual entity
| <idno type="URI">http://syriaca.org/work/5503/tei</idno> | ||
| <textLang mainLang="syr"/> | ||
| <noteGrp type="abstract"> | ||
| <desc xml:lang="en">Disputation between Timothy and the caliph al-Mahdi set up in the form of questions and answers</desc> |
There was a problem hiding this comment.
The desc should just say "Abstract" -> this is a human-readable label for the "Abstract" section. The abstract itself should go in the child note element, i.e. between lines 98 and 99
| <bibl source="#bib5503-1" xml:id="bib1000-3" type="lawd:Edition"> | ||
| <title xml:lang="de">Timotheos I. Ostsyrischen Patriarch: Disputation mit dem Kalifen al-Mahdi</title> | ||
| <author>Heimgartner M.</author> | ||
| <ptr target="https://syriaca.org/cbss/VXIZDJ8R"/> |
There was a problem hiding this comment.
Careful of "https" vs "http", Syriaca URIs should be http
| <listBibl type="editions"> | ||
| <head>Editions</head> | ||
| <desc xml:lang="en">This is not a comprehensive list of editions related to this work. Further citations may be available through <ref target="http://syriaca.org/cbss">The Comprehensive Bibliography on Syriac Studies</ref>.</desc> | ||
| <bibl source="#bib5503-1" xml:id="bib1000-3" type="lawd:Edition"> |
There was a problem hiding this comment.
The bibl IDs should follow the format of bib5503-n (i.e., the main numerical portion should match the file name/URI for the work).
There was a problem hiding this comment.
Also a question on your use of the source attribute: is this intended to say that the edition is using the manuscript bibl as a witness? If so, we would want to encode this in a slightly different way, cf. https://syriaca.org/documentation/schemas/syriacaWorks.compiled.html#editionManuscriptLink in the guidelines
Processed feedback by Will
Correction line 99
2 participants
Created, filled in, and attempted for the record 5503, the Apology of Timothy. I know there are some incompletions and inconsistencies in the file, but I did not know how to correct them.