feat: remove product config & clean up#716
Open
maltesander wants to merge 74 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Replaces product-config's writer module. Lives in framework::writer and renders hive-site.xml (Hadoop XML) and security.properties (Java properties), matching product-config's output. Also scaffolds controller/build with placeholders for the per-file builders. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… builders Reshape ValidatedCluster (name, image, cluster_config, role_group_configs) and validate via framework::role_utils::with_validated_config. Build hive-site.xml, security.properties and core-site.xml via dedicated builders + the vendored writer. Switch HiveConfigOverrides to v2 KeyValueConfigOverrides (key-by-key Merge). product-config is now only referenced by the crd Configuration impl. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Remove the Configuration impl for MetaStoreConfigFragment and the product-config crate from the workspace. product-config now only appears transitively via stackable-operator. The deploy/config-spec packaging is left in place to mirror trino-operator (it is operator-templating-managed infrastructure). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Resolve the JDBC driver, Kerberos hive-site entries and the core-site decision into ValidatedClusterConfig during validation, so hive_site/core_site builders consume only ValidatedClusterConfig. config_map keeps an explicit `owner: &HiveCluster` solely for the ObjectMeta owner reference. Rename the reconcile binding `validated` -> `validated_cluster`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
16 tasks
Replace the vendored java-properties/Hadoop-XML writer (rust/operator-binary/src/framework/writer.rs) with stackable_operator::v2::config_file_writer, which hosts the same code (moved there verbatim via operator-rs #1217 on the smooth-operator branch; hive's copy was byte-identical to hdfs's, the canonical source). Drop the now-unused java-properties and xml dependencies. The framework module now only contains role_utils. The base dependency tag moves from stackable-operator-0.111.0 to 0.111.1, matching the other operators; cargo only substitutes a [patch] whose package version matches, and the smooth-operator branch carries 0.111.1. No behaviour change; rendered output is byte-identical by construction (same code, new home). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…overy_configmap (provided in ValidatedCluster)
Member
Author
|
…n build_config_map
maltesander
commented
Jun 16, 2026
siegfriedweber
requested changes
Jun 16, 2026
Comment on lines
+48
to
+55
| metadata: cluster | ||
| .object_meta( | ||
| cluster | ||
| .resource_names(role_group_name) | ||
| .metrics_service_name() | ||
| .to_string(), | ||
| role_group_name, | ||
| ) |
Member
There was a problem hiding this comment.
The build step sneaked into the ValidatedCluster implementation.
In my opinion, the methods of ValidatedCluster should only provide different views on this object, but not implement parts of the controller steps. Otherwise you could move everything into it, e.g. build_statefulset_out_of_this_cluster. I would move methods like ValidatedCluster::object_meta, ValidatedCluster::role_group_selector and ValidatedCluster::recommended_labels to the build step.
Co-authored-by: maltesander <malte.sander.it@gmail.com> Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Member
Author
|
One failure because of namespace deletion |
siegfriedweber
requested changes
Jun 17, 2026
Member
|
This pull request has reached a size I can no longer review reliably. I’ll do my best, but I can’t make any guarantees. |
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker