chore: Bump kube and k8s-openapi as well as other crates#1224
Open
sbernauer wants to merge 4 commits into
Open
chore: Bump kube and k8s-openapi as well as other crates#1224sbernauer wants to merge 4 commits into
sbernauer wants to merge 4 commits into
Conversation
|
|
||
| if let Err(err) = recorder | ||
| .publish(&error_to_event(error), &obj.clone().into()) | ||
| .publish(&error_to_event(error), &(*obj.clone()).into()) |
Member
There was a problem hiding this comment.
Curious what happened there. I assume a type change.
| ### Changed | ||
|
|
||
| - BREAKING: Use `serde_json::Value` instead of `String` for user-provided JSON `configOverrides`. This change is marked as breaking, as it causes a breaking change to the CRDs ([#1206]). | ||
| - BREAKING: Bump to kube `4.0.0`, k8s-openapi `0.28.0` and enable the Kubernetes 1.36 feature ([#1224]). |
Member
There was a problem hiding this comment.
Do we need to 😅?
Have we tried it on some of our CRDs to see what changes this time?
NickLarsenNZ
approved these changes
Jun 18, 2026
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
Member
There was a problem hiding this comment.
LGTM, but I am wary about the kube-rs update (it brings back some traumas of past bumps :/)
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Definition of Done Checklist
Author
Reviewer
Acceptance