add metrics endpoint for csi#178
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
nschad
left a comment
There was a problem hiding this comment.
You also need to add the port to the Service
| app: {{ .Values.prefix }}-csi | ||
| role: controller | ||
| name: {{ .Values.prefix }}-csi-driver-controller | ||
| namespace: {{ .Release.Namespace }} |
There was a problem hiding this comment.
@nschad not sure about the namespace, the ccm service exist in kube-system ns.
|
@aniruddha2000: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
This PR exposes endpoint and port for csi metrics using external APIs
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Breaking changes: