Skip to content

add metrics endpoint for csi#178

Open
aniruddha2000 wants to merge 4 commits into
mainfrom
add-generic-metrics
Open

add metrics endpoint for csi#178
aniruddha2000 wants to merge 4 commits into
mainfrom
add-generic-metrics

Conversation

@aniruddha2000

Copy link
Copy Markdown
Member

How to categorize this PR?

/kind enhancement
What this PR does / why we need it:

This PR exposes endpoint and port for csi metrics using external APIs

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

@ske-prow ske-prow Bot added the kind/enhancement Enhancement, improvement, extension label Jun 17, 2026
@ske-prow

ske-prow Bot commented Jun 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xoxys for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 17, 2026

@nschad nschad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add the port to the Service

@ske-prow ske-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2026
app: {{ .Values.prefix }}-csi
role: controller
name: {{ .Values.prefix }}-csi-driver-controller
namespace: {{ .Release.Namespace }}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nschad not sure about the namespace, the ccm service exist in kube-system ns.

@ske-prow

ske-prow Bot commented Jun 22, 2026

Copy link
Copy Markdown

@aniruddha2000: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-extension-provider-stackit-integration-tests d318c21 link true /test pull-gardener-extension-provider-stackit-integration-tests

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see the gardener testing guideline for how to avoid and hunt flakes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Enhancement, improvement, extension size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants