ci: SDK pipeline hardening using custom action and commit hashes instead of tags#53
Open
tuunit wants to merge 1 commit into
Open
ci: SDK pipeline hardening using custom action and commit hashes instead of tags#53tuunit wants to merge 1 commit into
tuunit wants to merge 1 commit into
Conversation
…ead of tags Signed-off-by: Jan Larwig <jan@larwig.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In light of recent events on GitHub, NPM and the whole Open Source ecosystem we shouldn't rely on random github actions like
shimataro/ssh-key-action@v2for simple tasks such as adding an SSH key and known hosts. As well as use git commit hashes instead of tags to ensure we don't fall victim to a repository / org takeover as has happened with fake Trivy tags