Fix dropped progress frames in POST-SSE responses - #6491
Open
isaacgao4396 wants to merge 1 commit into
Open
Conversation
Signed-off-by: isaacgao4396 <gaoyuan4396@gmail.com>
isaacgao4396
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
blkt,
jhrozek and
rdimitrov
as code owners
September 2, 2026 15:45
jhrozek
approved these changes
Sep 3, 2026
jhrozek
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the fix — closes a genuine select-ordering race where a buffered progress notification could be skipped in favor of the final response. Drain-before-final logic is correct given dispatchResponses' strict per-channel ordering, and the new tests cover the ordering, no-op, and write-failure cases. LGTM.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6491 +/- ##
==========================================
+ Coverage 78.09% 78.25% +0.15%
==========================================
Files 768 769 +1
Lines 74551 75061 +510
==========================================
+ Hits 58220 58737 +517
+ Misses 16326 16319 -7
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Fixes #6349