fix(patterns): reject future review provenance#4
Merged
Conversation
Owner
Author
|
Post-CI diff review complete.
Evidence: local and remote heads match; the PR contains 7 files and the required behavior, tests, and docs commits; git diff --check and privacy scanning pass; two workflow runs are green; and the GitHub job log confirms the new validator-contract test step completed successfully. No reviewer or bot concerns are outstanding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design decision
Use a small policy-oriented unittest matrix rather than enumerating Markdown syntax. The tests exercise existing public validator functions with isolated temporary repositories and add no dependency.
Main risk
The future-date rule uses the runner calendar date. It intentionally rejects impossible provenance claims but does not introduce a freshness or expiration SLA for historical reviews.
Compatibility impact
Existing cards remain valid. A card with a future last_reviewed value now fails local and remote validation with a stable error.
Rollback path
Revert the documentation commit, the test/CI commit, and then the behavior commit. No persisted data or schema migration is involved.
Verification
Fixes #3