fix(manifest): preserve shipped config digest#86
Merged
Conversation
Owner
Author
|
Post-CI diff review completed.
Reviewed the complete four-file remote diff after both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The v1.2.0 external clean-clone release gate exposed a reproducibility bug.
scripts/regenerate_artifacts.pyparsed and re-serialized the shipped YAML before running the pipeline, while the public CLI hashes the original file bytes. Both paths used equivalent configuration values but produced differentconfig_digestidentities.Verification
.venv\\Scripts\\python.exe -m pytest -q— 190 passed.venv\\Scripts\\python.exe scripts/regenerate_artifacts.py --check— 29 strict artifacts matched; 6 visual snapshots regenerated without byte comparison.venv\\Scripts\\python.exe -m build— built the 1.2.0 wheel and source distributionRelease decision record
Release gate
This PR does not create a tag or release. After merge, the candidate must pass a fresh external clean-clone reproduction, and the new exact commit requires explicit release approval because the existing authorization names
44d755f.