Conversation
Contributor
Author
|
Unfortunately, the mac R-devel workflow will still fail until this PR is merged upstream: r-lib/actions#1108 |
Member
|
Thanks @andrjohns, this is great. I’ll take a closer look soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several tests were failing due to changes in the outputs from other packages that were being compared against (e.g.,
lme4) as well as the reliance on deprecated syntax fromggplot2.I've also updated the actions workflow to use the built-in concurrency handling (instead of the custom
n1hility/cancel-previous-runsworkflow) and automatically detect and install all suggested deps instead of the hand-maintained list.This PR also updates the test syntax for testthat 3e, enabling running the tests in parallel.
I've tried to keep the changes grouped by commit so it's easier to review, plus an (AI-generated) summary below, but let me know if it would be better split into multiple PRs!
Summary
This branch gets CI running again and updates the package and its tests for newer versions of its dependencies (lme4, loo, bayesplot, ggplot2, testthat and roxygen2).
VarCorr.stanreg(R/stanreg-methods.R): each matrix now has classc("vcmat_us", "matrix", "array"), to match what current lme4 returns.get_common_cnms(R/jm_data_block.R): the result is now sorted by name, so the grouping-factor order is the same in every submodel ofstan_jm/stan_mvmer.pp_check(R/pp_check.R):ppc_error_scatter_avgnow gets the defaultx = 1:length(y), likeppc_intervals,ppc_ribbonandppc_error_binnedalready did.plot_nonlinear(R/stan_gamm4.R):aes_()(deprecated) is replaced byaes(), andsizebylinewidthfor lines and ribbons.NULLlocally removes the R CMD check "no visible binding" NOTEs.context().expect_equivalent/check.attributes = FALSEbecameignore_attr = TRUE.tol =becametolerance =.expect_isbecameexpect_s3_class,expect_typeorinherits().r_eff = TRUEto match the implementation.posterior_predict: the helper had a typo,regexep, so the error message was never checked. It is nowregexpwith the current message.ppc_calibration*,ppc_dots,ppc_loo_calibration*,ppc_loo_pit_ecdf) are excluded from the generic loop.ITERgoes from 100 to 200.