Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1711 +/- ##
==========================================
- Coverage 92.50% 92.48% -0.03%
==========================================
Files 69 69
Lines 10367 10374 +7
==========================================
+ Hits 9590 9594 +4
- Misses 777 780 +3
🚀 New features to boost your workflow:
|
Member
|
The name base-unix is a bit misleading because it is really part of the standard library, it’s just conditionally linked. Is there a reason you’d like to avoid this? |
Contributor
Author
|
Nothing too essential or critical, just exploring the C bytecode bundling again (for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
stanccurrently uses thefmt.ttylibrary to setup terminal outputs and formatting but this pulls inbase-unixas a runtime dependency. This PR removes thefmt.ttydependency in favour of a small helper providing the same formatting and setupRelease notes
Removed
fmt.ttydependencyCopyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)