fix: explicit probability 0 means never (unset stays always) - #1
Merged
Merged
Conversation
Match clamped probability <= 0 up to 1.0, so a rule that explicitly asked to fault 0% of connections faulted 100% instead. The zero value could not express 'never'. Make Rule.Probability a *float64: nil (unset) defaults to always, an explicit value — including 0 (never) — is honored. The CLI flag defaults to 1 (always) and the JSON DTO defaults nil to always, so 'omit = always' is preserved while 0 now correctly means never.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fault.Matchclampedprobability <= 0up to1.0, so a rule explicitly configured to fault 0% of connections faulted 100% instead. The float zero-value could not express "never" — it was indistinguishable from "unset".Fix
Rule.Probabilitybecomes*float64:The CLI flag
--fault-probabilitynow defaults to1(always), and the JSONRuleDTOdefaultsnilto always. So "omit = always" is unchanged, while an explicit0now correctly means never.This pairs with the extension change (
percentageToProbabilityclamps to [0,1]), so a 0% Percentage in the UI now means "never fault" as expected.Tests
TestMatch_UnsetProbabilityMeansAlways(nil → always)TestMatch_ExplicitZeroProbabilityMeansNever(0 → never)