fix(home): keep a single main landmark on the homepage - #104
Merged
Conversation
The homepage renders inside DocsLayout, which already provides the main#nd-docs-layout landmark, so the page-level main created a nested duplicate. Swap the inner wrapper to a div and assert in the homepage e2e test that exactly one main element is rendered.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main#nd-docs-layoutlandmark. The page-level<main>inapp/(home)/_pages/page.en.tsxcreated a nested duplicate main landmark, which is invalid HTML and confuses assistive tech.div, keeping the className unchanged, so the layout's main remains the single landmark. PR fix(home): improve homepage semantics #98 fixed the heading semantics but missed this.app/(home)/_pages/has no other page variants, so this is the only page-level fix needed.Test plan
<mainelement. Verified it fails on the old markup (2 matches) and passes with the fix.bun test tests/e2e/llm-endpoints.test.ts: 22 pass, 0 fail.bun run checkandbun run typecheck: clean.