fix(skills): skip the index on GitHub transport errors instead of failing the build - #108
Merged
Merged
Conversation
…ling the build PR #95 rewrote the generator and dropped the deploy-safe error handling from PR #89, so any GitHub outage, 5xx, or exhausted rate limit aborted the whole production build via bun run generate. Restore the intended two-tier split: - Transport errors (fetch network failures, non-ok GitHub responses, rate limits) are classified as GitHubTransportError. The entrypoint warns and exits 0, leaving the index absent for that deploy. - Schema, packaging, validation, and filesystem errors still throw and fail the build, so a malformed index can never ship. The script writes nothing before every artifact validates, so skipping on a transport error leaves no partial output behind.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #95 rewrote
scripts/generate-agent-skills-index.tsand dropped the deploy-safe error handling that PR #89 introduced, leavingif (import.meta.main) { await main(); }bare. Sincebun run buildrunsgeneratefirst, any GitHub outage, 5xx, or exhausted rate limit aborted the whole production build for a non-core discoverability feature.This restores #89's intent as a two-tier split:
GitHubTransportErrorclass covers non-ok GitHub responses (viagithubRequestError, including rate-limit exhaustion) and raw fetch network failures (via a smallgithubFetchwrapper). The entrypoint catches only this class, warns, and exits 0, leaving the index absent for that deploy: honest rather than stale.Test plan
tests/agent-skills-index.test.ts:GitHubTransportErrorGitHubTransportErrorwith guidance in the messageGitHubTransportErrorviagithubFetchbun test tests/agent-skills-index.test.ts: 32 passbun test: 302 passbun run check: clean