fix(imagegen): share one chromium across test renders to avoid spawn deadlocks - #111
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The imagegen CI flake was not slow runners: with the timeout raised to 240s (#110), the failing test died at 180s, which is Playwright's own browser launch timeout, with chrome-headless-shell stuck at launching. Repeated chromium.launch() calls in the same Bun test process intermittently deadlock on spawn; cli.test.ts already documents this pattern for subprocess spawns. The first launch always succeeds, so the fix is to launch once and reuse.
Side effect: the full test suite drops from about 195s to about 28s, since Chromium launches once instead of per render.
Test plan