Backport a few patches for v0.8.11

[stefanberger]

This PR backports a few patches for v0.8.11

Summary by CodeRabbit

• Bug Fixes
  • Improved input handling during data parsing by rejecting negative buffer sizes.
  • Prevented potential out-of-bounds reads and invalid memory copies when processing insufficient or malformed data.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 8c8a33a5-df56-4565-991f-6bd1234177f7

📥 Commits

Reviewing files that changed from the base of the PR and between e99bb7e and 4ab38b7.

📒 Files selected for processing (1)

• src/tpm2/Unmarshal.c

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The primitive unmarshaling functions now reject negative remaining-buffer sizes with TPM_RC_INSUFFICIENT. This prevents invalid size conversions and memory-copy lengths.

Changes

Unmarshaling validation

Layer / File(s)	Summary
Reject negative remaining-buffer sizes src/tpm2/Unmarshal.c	UINT8_Unmarshal, UINT16_Unmarshal, UINT32_Unmarshal, UINT64_Unmarshal, and Array_Unmarshal return TPM_RC_INSUFFICIENT before reading or copying data when *size is negative.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 4ab38

TPM unmarshaling now rejects invalid negative buffer sizes before processing data, preventing unsafe length conversion and memory access. The change is ready to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately identifies the primary change as backporting patches for the v0.8.11 release. It is concise and relevant, although it does not describe the negative-size validation details.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch stable-0.8.next

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}