fix(widget): remove unintended dark background overlay#2354
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 20, 2026, 5:40 AM ET / 09:40 UTC. Summary Reproducibility: no. independent current-main reproduction was run in this review; the contributor’s paired inactive-desktop screenshots provide convincing after-fix visual evidence for the reported rendering path. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Next step before merge
Security Review detailsBest possible solution: Merge this narrowly scoped visual fix after ordinary maintainer review, preserving WidgetKit’s existing system-managed container background across all affected widget families. Do we have a high-confidence way to reproduce the issue? No independent current-main reproduction was run in this review; the contributor’s paired inactive-desktop screenshots provide convincing after-fix visual evidence for the reported rendering path. Is this the best way to solve the issue? Yes. Removing the unintended custom overlay while retaining WidgetKit’s existing AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against f8636cb37eb0. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (3 earlier review cycles) |
There was a problem hiding this comment.
Pull request overview
Removes an unintended dark inset overlay in the WidgetKit widget views by dropping the explicit translucent black background layer and relying on containerBackground instead, while also ensuring each widget view expands to fill its container for consistent inactive-desktop rendering.
Changes:
- Removed the
ZStack { Color.black.opacity(0.02) ... }overlay pattern from widget views. - Ensured widget root content expands to the full widget bounds via
.frame(maxWidth: .infinity, maxHeight: .infinity). - Adjusted the switcher widget layout so padding/content sizing remains consistent without the extra background layer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Fix an unintended dark rectangular overlay that appears inside desktop widgets when the desktop is inactive.
Changes
Screenshots
Testing
make checkmake testNotes