Fix reverse connection recovery#30
Merged
Merged
Conversation
StephenCWills
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a reverse connection, the subscriber is the server/listener and therefore owns the only reliable application-level indication that published data has stopped arriving. The intended data monitor was gated by an inverted condition: it attempted to enable the timer only when the timer was already enabled. As a result, a half-open connection -- such as one left behind by a temporary firewall outage -- could remain established without the subscriber forcing the publisher client through its normal reconnect cycle.
The reverse recovery path now uses the existing transport behavior:
DataLossIntervalDisconnectOnefor its sole publisher connectionConnectAsyncWith change, reverse STTP connections can recover when the transport remains half-open but measurement data has stopped flowing. Normal subscriber/client-to-publisher/server operation is unchanged.