Fixed #1164 Improve Reproducibility Message - #1167
Merged
seanlaw merged 2 commits intoJul 31, 2026
Merged
Conversation
|
Review these changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1167 |
Contributor
Author
|
@NimaSarajpoor I think this is ready to be merged. Would you mind providing your thoughts? |
NimaSarajpoor
left a comment
NimaSarajpoor
left a comment
Collaborator
There was a problem hiding this comment.
@seanlaw
That was fast! I added two minor comments for your consideration. Nothing else stood out to me.
|
|
||
| # Note that an initial SEED = 0 is disallowed | ||
| # in order to account for unit testing | ||
| if os.getenv("STUMPY_SEED") is not None: # pragma: no cover |
Collaborator
There was a problem hiding this comment.
we should check if os.getenv("STUMPY_SEED") is 0, and raise an error if that is true.
| pytest.STUMPY_MSG = ( | ||
| f"\n\nSTUMPY_STATE='{state_str}' pixi run tests custom {config.args[0]}" | ||
| f"\n\nSTUMPY_SEED={rng.SEED} {env_vars} " | ||
| f"pixi exec {specs} ./test.sh custom 1 {config.args[0]}" |
Collaborator
There was a problem hiding this comment.
Not a must have... but I think it should be good to have a + between the two strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1164
Pull Request Checklist
Below is a simple checklist but please do not hesitate to ask for assistance!
black(i.e.,python -m pip install blackorconda install -c conda-forge black)flake8(i.e.,python -m pip install flake8orconda install -c conda-forge flake8)pytest-cov(i.e.,python -m pip install pytest-covorconda install -c conda-forge pytest-cov)black --exclude=".*\.ipynb" --extend-exclude=".venv" --diff ./in the root stumpy directoryflake8 --extend-exclude=.venv ./in the root stumpy directory./setup.sh dev && ./test.shin the root stumpy directory