fix: stabilize test_stump.py by reducing extreme values in test data (closes #1160) - #1168
Closed
botbikamordehai2-sketch wants to merge 1 commit into
Closed
Conversation
|
Review these changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1168 |
|
❌ This pull request has been automatically closed because the mandatory PR template was removed or not filled out. Please reopen or recreate this PR with the required information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The test failure in test_stump.py occurs because the naive and performant matrix profile computations differ for the given test data. The first test data contains extreme values (e.g., 8100 and 1001) that can cause numerical precision issues when comparing results with
npt.assert_almost_equalat default tolerance. This leads to flaky failures, especially when a random seed is set.Fix
Reduce the magnitude of the first test data set to values that are less likely to cause floating-point discrepancies. This makes the test more robust and deterministic without changing the test's coverage of the core functionality.
Closes #1160