POC: iceberg-testing conformance fixtures#1
Open
sungwy wants to merge 1 commit into
Open
Conversation
This was referenced Jun 26, 2026
There was a problem hiding this comment.
Pull request overview
Adds a proof-of-concept conformance test harness that runs the language-neutral sungwy/iceberg-testing fixtures against PyIceberg via a pinned git submodule, to validate spec-defined behaviors across implementations.
Changes:
- Adds a pytest harness to execute fixture cases for type-string parsing/canonicalization, bucket hash known-answer tests, and delete-file decoding by field-id.
- Documents how to initialize the submodule and run the conformance tests.
- Introduces an
iceberg-testing/git submodule entry.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/conformance/test_iceberg_testing.py |
New pytest harness that discovers and runs conformance fixtures, with explicit xfail coverage for known gaps. |
tests/conformance/README.md |
Runbook describing fixture coverage and how to execute the conformance tests locally. |
.gitmodules |
Adds the iceberg-testing submodule URL/path wiring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sungwy
force-pushed
the
conformance-iceberg-testing
branch
2 times, most recently
from
1118657 to
eeb9639
Compare
Pin sungwy/iceberg-testing as a git submodule and add a pytest conformance suite that walks its language-neutral fixtures against PyIceberg: - test_type_strings.py parse + exact re-serialize (canonical type strings) - test_bucket_hash.py the Appendix B 32-bit hash Known-Answer-Test - test_delete_formats.py positional/equality delete-file decode by field-id - _shared.py fixtures path, submodule-absent skip marker, load_jsonl Cases PyIceberg does not yet satisfy are xfail with the tracking issue (apache/iceberg#16798, apache#3004, apache#3522); removing an entry when it lands shows up as an XPASS. The lint-and-unit-test CI job checks out the submodule so the suite runs, and the tests skip cleanly when it is absent. .gitmodules and the submodule are excluded from the RAT license check. 19 pass, 6 xfail.
sungwy
force-pushed
the
conformance-iceberg-testing
branch
from
eeb9639 to
f379f51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC wiring the language-neutral conformance fixtures from sungwy/iceberg-testing into PyIceberg as a pinned git submodule, with a pytest harness that walks them.
Test Surfaces: type-string parse + re-serialize, the Appendix B bucket-hash Known-Answer-Test, and delete-file decode by field-id.
Result here: 19 pass, 6 xfail. The xfails are known issues on PyIceberg side. Issue links are noted next to the expected failing cases.
Run: