fix: support redirect-to header to resolve Envoy proxy rejection (#2833) - #2834
Open
rajat12826 wants to merge 1 commit into
Open
rajat12826 wants to merge 1 commit into
rajat12826 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
What is the current behavior?
Envoy proxy has a security-hardening configuration (
headers_with_underscores_action: REJECT_REQUEST) that rejects HTTP headers containing underscores. Because GoTrue relied on theredirect_toHTTP header, requests routing through self-hosted Envoy proxies (like the ones configured via Supabase Docker deployments) were rejected as bad requests, breaking authentication redirect flows.Resolves #2833
What is the new behavior?
This PR introduces support for the
redirect-toheader (without underscores) while safely falling back to the legacyredirect_toheader for backward compatibility. This applies to both HTTP headers and form/query parameters.getRedirectToininternal/utilities/request.goto extractredirect-toand fallback toredirect_toTestGetReferrerinsideinternal/utilities/request_test.goto explicitly test and verify both variants of the headerAdditional context
This follows Envoy's standard recommendation that non-standard HTTP headers should utilize hyphens instead of underscores to pass through proxies correctly. All existing tests pass and the solution ensures no existing API usage breaks.