Skip to content

fix(start-server): stop and exit when a setup step fails #2489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
breken-ai wants to merge 1 commit into from
+17 −9
Closed

fix(start-server): stop and exit when a setup step fails #2489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions nix/tools/run-server.sh.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,14 @@ stop_postgres() {
fi
}

# Setup failed: stop the server that was started for setup (in either mode) and
# exit non-zero, instead of carrying on with a partially initialized database.
abort_setup() {
echo "Error: database setup failed, stopping PostgreSQL" >&2
pg_ctl stop -D "$DATDIR" -m fast || true
exit 1
}

trap 'stop_postgres' SIGINT SIGTERM

# Parse arguments
Expand Down Expand Up @@ -311,7 +319,7 @@ for i in {1..60}; do
sleep 1
if [ $i -eq 60 ]; then
echo "PostgreSQL failed to start"
'stop_postgres' 1
abort_setup
fi
done

Expand All @@ -328,47 +336,47 @@ if [ "$SKIP_MIGRATIONS" = false ]; then
alter database postgres owner to postgres;
EOSQL
then
'stop_postgres' 1
abort_setup
fi

if [ -n "$MIGRATION_FILE" ]; then
echo "Running user-provided migration file $MIGRATION_FILE"
if ! psql -v ON_ERROR_STOP=1 --no-password --no-psqlrc -U "$PGSQL_SUPERUSER" -p "$PORTNO" -h localhost -f "$MIGRATION_FILE" postgres; then
'stop_postgres' 1
abort_setup
fi
else
# Run default init scripts
for sql in "$MIGRATIONS_DIR"/init-scripts/*.sql; do
echo "Running $sql"
if ! psql -v ON_ERROR_STOP=1 --no-password --no-psqlrc -U "$PSQL_USER" -p "$PORTNO" -h localhost -f "$sql" postgres; then
'stop_postgres' 1
abort_setup
fi
done

# Set superuser password
if ! psql -v ON_ERROR_STOP=1 --no-password --no-psqlrc -U "$PSQL_USER" -p "$PORTNO" -h localhost -c "ALTER USER supabase_admin WITH PASSWORD '$PGPASSWORD'"; then
'stop_postgres' 1
abort_setup
fi

# Run additional schema files
if ! psql -v ON_ERROR_STOP=1 --no-password --no-psqlrc -U "$PSQL_USER" -p "$PORTNO" -h localhost -d postgres -f "$PGBOUNCER_AUTH_SCHEMA_SQL"; then
'stop_postgres' 1
abort_setup
fi
if ! psql -v ON_ERROR_STOP=1 --no-password --no-psqlrc -U "$PSQL_USER" -p "$PORTNO" -h localhost -d postgres -f "$STAT_EXTENSION_SQL"; then
'stop_postgres' 1
abort_setup
fi

# Run migrations as superuser
for sql in "$MIGRATIONS_DIR"/migrations/*.sql; do
echo "Running $sql"
if ! psql -v ON_ERROR_STOP=1 --no-password --no-psqlrc -U "$PGSQL_SUPERUSER" -p "$PORTNO" -h localhost -f "$sql" postgres; then
'stop_postgres' 1
abort_setup
fi
done

# Run PostgreSQL schema
if ! psql -v ON_ERROR_STOP=1 --no-password --no-psqlrc -U "$PGSQL_SUPERUSER" -p "$PORTNO" -h localhost -f "$POSTGRESQL_SCHEMA_SQL" postgres; then
'stop_postgres' 1
abort_setup
fi
fi
fi
Expand Down