Repository navigation
fix(playback): report the software host's actual video decoder - #760
Open
andreencar wants to merge 1 commit into
Open
andreencar wants to merge 1 commit into
andreencar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the software playback host selects VideoToolbox for HEVC,
activeVideoDecodernow reportsVideoToolbox HEVC (HW)instead oflibavcodec HEVC (SW). The label follows the selected decoder on both initial load and reload, without changing decoder selection or playback routing.Closes #753
What changed
Test plan
bash Scripts/fetch-fixtures.sh(no audio or Dolby Vision):hdr10-hevc.mp4: MP4, HEVC Main 10, 1920×1080, 10-bit 4:2:0, HDR10/PQ →VideoToolbox HEVC (HW).hev1-inband-xps.mp4: MP4, HEVC Main, 320×240, 8-bit 4:2:0, in-band parameter sets, no HDR metadata →libavcodec HEVC (SW).vp9.webm: WebM, VP9 Profile 0, 1920×1080, 8-bit 4:2:0, no HDR metadata →libavcodec VP9 (SW).av1.mp4: MP4, AV1 Main, 1920×1080, 8-bit 4:2:0, no HDR metadata →dav1d AV1 (SW).playbackBackendremains.software. Before the fix, the hardware HEVC test failed both label assertions; the software cases passed.swift testpasses (4,349 Swift Testing tests and 17 XCTest tests); the macOS demo builds; documentation-link and whitespace checks pass. Revalidated after rebasing onto the latestmain.Checklist
CHANGELOG.mdupdatedfeat(...),fix(...),chore(...))